solid-contrib / pivot

A spec-compliant Solid server, based on a remix of CSS
MIT License
7 stars 1 forks source link

Deal with non-existing emails in migration #9

Open michielbdejong opened 11 months ago

thhck commented 11 months ago

Should we use a email that we ( the solidcommunity.net administrator ) control instead of a virtual one used by NSS2CSS ?

michielbdejong commented 11 months ago

Although the expected arguments suggests that xxx acts as a template variable in xxx@users.css.pod, looking at [how this argument is used]() it seems we can only use it as a way to define the value for emailDomain.

> 'xxx@users.css.pod'.replace(/.*@+/, '');
'users.css.pod'
> 'xxxusers.css.pod'.replace(/.*@+/, '');
'xxxusers.css.pod'
> 'xxx@users.cs@s.pod'.replace(/.*@/, '');
's.pod'
> 'solidcommunity.net'.replace(/.*@/, '');
'solidcommunity.net'
> 'any@thing@solidcommunity.net'.replace(/.*@/, '');
'solidcommunity.net'
> 'blackhole.solidcommunity.net'.replace(/.*@/, '');
'blackhole.solidcommunity.net'

So I suggest we set the emailPattern argument to blackhole.solidcommunity.net so that it's clear that these emails will not have mailboxes behind them in general.

And then I think there is a step missing from the migration script which we should probably add ourselves: to extract the real email address from the root /.acl file of each NSS pod, and use that as the email address for the CSS pod. Only if that process fails we can fall back to assigning an @blackhole.solidcommunity.net email address.

Here you see for instance that the email address for michielbdejong.solidcommunity.net is michiel@unhosted.org:

Screenshot 2023-11-29 at 12 05 42
bourgeoa commented 11 months ago

And then I think there is a step missing from the migration script which we should probably add ourselves: to extract the real email address from the root /.acl file of each NSS pod, and use that as the email address for the CSS pod. Only if that process fails we can fall back to assigning an @blackhole.solidcommunity.net email address.

I see 2 issues with the proposal to use root/.acl email :

CSS v7 allows for multiple accounts (email/password) for the same pod. A solution could be found around creating a second account with the NSS user email/password when the email was not already used.

So I suggest we set the emailPattern argument to blackhole.solidcommunity.net so that it's clear that these emails will not have mailboxes behind them in general.

Well. Why not, but being a fake emailDomain make it short.