login() parameter is 'redirect', not 'redirectUrl' - Githubissues

solid-contrib / solid-auth-fetcher

A client library for authenticating with Solid

Other

2 stars 6 forks source link

login() parameter is 'redirect', not 'redirectUrl' #22

Closed WhyINeedToFillUsername closed 6 months ago

WhyINeedToFillUsername commented 3 years ago

This PR fixes the readme file.

[ ] I've added a unit test to test for potential regressions of this bug.
[ ] The changelog has been updated, if applicable.
[x] Commits in this PR are minimal and have descriptive commit messages.

josephguillaume commented 3 years ago

This is correct and can be merged. The redirect input option is defined in https://github.com/solid/solid-auth-fetcher/blob/1407fb9dacdfa8bf0cd31f397161ae27ce980704/src/ILoginInputOptions.ts#L49