search

solid-contrib / solid-auth-fetcher

A client library for authenticating with Solid
Other
2 stars 6 forks source link

Update Popup instructions in README #24

Closed josephguillaume closed 6 months ago

josephguillaume commented 3 years ago

The README currently describes the use of handlePopUpRedirect, which doesn't exist. The text has been updated to describe the use of handleRedirect, and to briefly describe how this works.

In case it's useful, here's the relevant implementation: https://github.com/solid/solid-auth-fetcher/blob/877dd07e8a0ecd00121414b21d1aeffbb72660d0/src/login/popUp/PopUpLoginHandler.ts#L62-L79

josephguillaume commented 3 years ago

Just to add that given that the storage of the accessToken is insecure, creating a handlePopUpRedirect function is not worth pursuing from a usability point of view, and requiring explicit calling of handleRedirect + closing the window increases transparency of how this actually works.