Closed fthobe closed 6 days ago
I'm closing this PR, and not because the changes in it aren't necessarily valid.
We expect individual changes to iterated on within a single PR using git rebase
. Making me hunt back through multiple PRs to find multiple pieces of feedback that explain the different changes in this PR is both unnecessary and annoying. Please make the changes to the original PRs and reopen them.
We like small, focused, well-explained PRs, not combinations of multiple PRs.
"Bugfix to _fonts.scss after font replacement" is not an acceptable commit description. Explain what you are doing and why.
Do not include merge commits in your PRs unless absolutely necessary.
I want to be clear that I honestly appreciate the enthusiasm your are showing towards Solidus. I appreciate the work you are doing and want to make the most of it. That said, we manage this project very carefully because many businesses depend on it and derive a ton of value from it. The best way to contributions merged into Solidus is to follow the lead of previous contributors and make your PRs as easy for us to review and understand as you can.
Summary
Add previously discussed I have:
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: