Open fthobe opened 3 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.96%. Comparing base (
bb0ed35
) to head (e28df85
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
π¨ Try these New Features:
This is a visual change as changes the fonts, but is missing screenshots showing the before/after.
The replacement of the font was a compliance issue, not a style contest. Please reach out to @kennyadsl about this. We will have to delete and hard fork our front-end repo if they are not removed. If you prefer a different font feel free to suggest it, just know that we can't provide any contributions till this is resolved.
Yes, we need to replace that font. As Fabian kindly pointed out, we cannot use that font on an open-source project (we bought the license for solidus.io. and its subdomains but apparently its usage here is not allowed). It needs to be replaced asap.
@fthobe true, this is not driven by an aesthetic requirement but has a visual impact, so if you have some screenshots of the starter frontend with the new font, it might speed up the merge. Let me know if you need any help with them.
BTW, we have some screenshot as artifact on the CircleCI failures:
BTW, we have some screenshot as artifact on the CircleCI failures:
@jarednorman Does that suffice?
Yes, this is good. While the change wasn't motivated by style, I still wanted to see how it changed to make sure we were choosing a reasonable alternate. Works for me.
Yes, this is good. While the change wasn't motivated by style, I still wanted to see how it changed to make sure we were choosing a reasonable alternate. Works for me.
Can we merge this please, I can't run anything with licensing problems on our systems.
Summary
This PR brings following improvements:
Following files have been modified as part of this commit:
Fixes: #379 #381
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: