Closed joanniclaborde closed 7 years ago
Looks good to me. Seems reasonable that the error
renders should be logged. The log entries on startup when docker-solidus
pings /dummy
are an issue that could be addressed in docker-solidus
, but it's probably not urgent. 👍
The special
error.hbs
file will most likely use a site's complex layout, which could expect to have all the fancy features that other pages have, like a full context, helpers, etc.This PR fully renders the error page like any other page, instead of just rendering the template with an empty context.
Side effect: each
error
render is logged, but that only happens in dev...