search

solo-io / gloo

The Cloud-Native API Gateway and AI Gateway
https://docs.solo.io/
Apache License 2.0
6 stars 0 forks source link

TestGlooGatewayEdgeGateway/Tracing/TestSpanNameTransformationsWithoutRouteDecorator #10365

Open sheidkamp opened 4 days ago

sheidkamp commented 4 days ago

Which tests failed?

TestGlooGatewayEdgeGateway/Tracing/TestSpanNameTransformationsWithoutRouteDecorator

E2e nightlies: https://github.com/solo-io/gloo/actions/runs/11886116108/job/33116812397

Error from server: error when creating "/home/runner/work/gloo/gloo/test/kubernetes/e2e/features/tracing/testdata/tracing.yaml": admission webhook "gloo.gloo-gateway-edge-test.svc" denied the request: resource incompatible with current Gloo snapshot: [Validating *v1.Gateway failed: 1 error occurred:
    * Validating *v1.Gateway failed: validating *v1.Gateway name:"gateway-proxy-tracing" namespace:"gloo-gateway-edge-test": 1 error occurred:
    * failed to validate Proxy [namespace: gloo-gateway-edge-test, name: gateway-proxy] with gloo validation: HttpListener Error: ProcessingError. Reason: *v1.Upstream { default.opentelemetry-collector } not found

Initial Investigation

No response

Additional Information

No response

jenshu commented 4 days ago

seen on 1.18 OSS PR https://github.com/solo-io/gloo/actions/runs/11897462860/job/33151782294?pr=10229

sheidkamp commented 3 days ago

Main nightlies: https://github.com/solo-io/gloo/actions/runs/11906576198/job/33178898060

sheidkamp commented 3 days ago

https://github.com/solo-io/gloo/pull/10363 should have fixed this (though it wasn't broken in OSS)

sheidkamp commented 3 days ago

Passed locally:

--- PASS: TestGlooGatewayEdgeGateway (171.25s)
    --- PASS: TestGlooGatewayEdgeGateway/Tracing (73.02s)
        --- PASS: TestGlooGatewayEdgeGateway/Tracing/TestSpanNameTransformationsWithoutRouteDecorator (18.46s)
PASS
sheidkamp commented 3 days ago

Seeing

=== NAME  TestGlooGatewayEdgeGateway/Tracing/TestSpanNameTransformationsWithoutRouteDecorator
    testing.go:1577: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test

in the logs, so no longer the namespace issue and likely related to https://github.com/solo-io/gloo/issues/10364

sheidkamp commented 2 days ago

But saw it with no timeout happening: https://github.com/solo-io/gloo/actions/runs/11927066435/job/33241873159 main nightlies.

Error from server: error when creating "/home/runner/work/gloo/gloo/test/kubernetes/e2e/features/validation/testdata/transformation/vs-transform-header-text.yaml": admission webhook "gloo.full-envoy-validation-test.svc" denied the request: resource incompatible with current Gloo snapshot: [Validating *v1.VirtualService failed: 1 error occurred:
    * Validating *v1.VirtualService failed: validating *v1.VirtualService name:"example-vs" namespace:"full-envoy-validation-test": 1 error occurred:
    * failed gloo validation resource reports: 2 errors occurred:
    * invalid resource full-envoy-validation-test.gateway-proxy
    * envoy validation mode output: error initializing configuration '': Failed to parse response template: Failed to parse

It looks like the fix for this should have been picked up