search

solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.08k stars 437 forks source link

Analyze all instances of non-test context.TODO() #7806

Open nfuden opened 1 year ago

nfuden commented 1 year ago

Version

None

Is your feature request related to a problem? Please describe.

As we strive to make our codebase more accessible we should remove footguns. One of these footguns is uncancellable context. This happens when context is not plumbed or ignored.

In particular for this we should remove all non-fallback instances of context.TODO() outside of tests. This will make us have better span information available for tracing as well as avoid issues like the glooctl usage in upgrade test footgun that we hit recently.

Describe the solution you'd like

For this to be considered complete all context.TODO() MUST either be in test code or have a comment as to why they are safe. This issue SHOULD attempt to correct any instances of TODO that can be replaced with a real context. For example in the consul plugin.

github-actions[bot] commented 3 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.