solo-spice / sospice

Python data analysis tools for the SPICE extreme-UV spectrometer on Solar Orbiter
BSD 3-Clause "New" or "Revised" License
12 stars 5 forks source link

File paths should be OS-agnostic #38

Open ebuchlin opened 7 months ago

ebuchlin commented 7 months ago

Currently some file paths (pathlib.Path objects) are converted to str using .as_posix(). This should rather be str(), to be OS-agnostic.

FileMetadata.get_file_url() should include a heuristics to discriminate base_urls that are URLs (.as_posix() is OK) compared to those that are local paths (use str() instead).

Or there should be a different argument for a base path than for a base URL.