solresol / solar-panel-astronomy

Doing lunar astronomy using domestic solar panels
The Unlicense
0 stars 0 forks source link

Sweep: lunar position program #2

Closed solresol closed 8 months ago

solresol commented 8 months ago

Details

Write a Python program moonpos.py that takes a --when command-line argument (which will be a ISO formatted date and time) and prints out where the moon was in the sky, and what phase it was in. Use whatever python libraries you need, just remember to add them to requirements.txt Create .github/workflows/test.yml which installs the python requirements, and runs moonpos.py with some suitable date time.

Checklist - [X] Create `moonpos.py` ✓ https://github.com/solresol/lunar-astronomy/commit/05645d81a034078791c03a33ffcfcc378c15723f [Edit](https://github.com/solresol/lunar-astronomy/edit/sweep/lunar_position_program/moonpos.py) - [X] Create `.github/workflows/test.yml` ✓ https://github.com/solresol/lunar-astronomy/commit/59c58f85d8bdeb1be736cd12503e0718737bf615 [Edit](https://github.com/solresol/lunar-astronomy/edit/sweep/lunar_position_program/.github/workflows/test.yml) - [X] Create `requirements.txt` ✓ https://github.com/solresol/lunar-astronomy/commit/2f09afad7037074b40e4fa289278dde81c65dfb5 [Edit](https://github.com/solresol/lunar-astronomy/edit/sweep/lunar_position_program/requirements.txt#L1-L1)
ifost-autodev[bot] commented 8 months ago

🚀 Here's the PR! #3

See Sweep's progress at the progress dashboard!
💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. (tracking ID: None)

[!TIP] I can email you next time I complete a pull request if you set up your email here!


Actions (click)

GitHub Actions failed

The sandbox appears to be unavailable or down.


Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I think are relevant in decreasing order of relevance (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/solresol/lunar-astronomy/blob/16d398b47e41bfc5452270274959ba22d0ba320a/LICENSE#L1-L15 https://github.com/solresol/lunar-astronomy/blob/16d398b47e41bfc5452270274959ba22d0ba320a/LICENSE#L15-L23 https://github.com/solresol/lunar-astronomy/blob/16d398b47e41bfc5452270274959ba22d0ba320a/README.md#L1-L1

Step 2: ⌨️ Coding


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/lunar_position_program.


🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord