search

solus-project / linux-steam-integration

Helper for enabling better Steam integration on Linux
GNU Lesser General Public License v2.1
430 stars 19 forks source link

Use `value` instead `default` keyword in with-shim build option #12

Closed alunux closed 6 years ago

alunux commented 6 years ago

Fix #11

ikeydoherty commented 6 years ago

Oops - thanks bud!

ikeydoherty commented 6 years ago

I assume the Arch package is yours? If so you'll want to take the CXX ABI patch and set -Dwith-new-libcxx-abi=true to ensure LD_PRELOAD is set when native runtime is disabled (running old crappy games basically). If not it'll be in a new point release which tbh I'm likely to end up doing today

alunux commented 6 years ago

@ikeydoherty I'm at Fedora 26. What happened to Arch package?

ikeydoherty commented 6 years ago

Oh right. Well - looks like your patch was used in the Arch package update - sorta assumed it was you lol. Do you have an active COPR? I'd like to list the various LSI repos on the main README :)

alunux commented 6 years ago

@ikeydoherty Are you an Archer now? xD Yes, I do, but I have not upgraded to v0.4 https://copr.fedorainfracloud.org/coprs/alunux/linux-steam-integration/

ikeydoherty commented 6 years ago

Oh I'm no Archer :P The package isn't mine lol. I try to track where my software is in the wider ecosystem :)

ikeydoherty commented 6 years ago

Tada https://github.com/solus-project/linux-steam-integration#getting-lsi

alunux commented 6 years ago

@ikeydoherty OMG! Thank you, man. Your softwares are too awesome. I use LSI and Budgie every day, but I don't know why I'm still using Fedora :|

ikeydoherty commented 6 years ago

We'll steal you soon enough @alunux :D

z3ntu commented 6 years ago

I'm maintaining the Arch package ^^ will make the changes you proposed

ikeydoherty commented 6 years ago

merci :)