search

solusio / solus-cloud-images

10 stars 10 forks source link

TASK SIO-4928 set GPT as default partition, update OSes #48

Closed avolovplesk closed 1 year ago

redikultsevsilver commented 1 year ago

Maybe it worth changing cloud_id as well? https://github.com/solusio/solus-cloud-images/blob/public/scripts/plesk/install_plesk.sh#L158 I doubt it's used anywhere at the moment, therefore adding some consistency to that file as well should not ruin anything in my opinion.

redikultsevsilver commented 1 year ago

What about changing the output_image_name for the windows builds, e.g. in windows/windows-2019-plesk.json, windows/windows-2019.json, windows/windows-2022-plesk.json, windows/windows-2022.json?

Also, I see that while you do rename the output images, from solus to solusvm, you do not rename the files themselves and the files are still called like centos/solus-centos-8-stream.json. Is is intentional?

avolovplesk commented 1 year ago

Added changes according to suggestions from redikultsevsilver