search

somakeit / smib

1 stars 0 forks source link

Seems possible to update the space state when state change network call is pending #236

Closed sjefferson99 closed 1 month ago

sjefferson99 commented 2 months ago

UI gives feedback that the space state change is pending, but not yet complete with display spinner and flashing lights, however, it can take a few seconds and it seems possible for users to try again in that time (open button starts hours open for state based on current space state, not on intended space state if trying to update).

Look into change space state requiring the space state to not be in flux (this has a timeout so should be fine) and check the UX once done to make sure it is clear.

sjefferson99 commented 1 month ago

First issue is stopping space poll when updating hours open.

sjefferson99 commented 1 month ago

0c93aa18fed32cdc93b897f46125c52639b13564 addresses space poll interrupting hours screen. Will test and see if other issues apply as postulated in issue title. Could be just this was causing the issues.

sjefferson99 commented 1 month ago

Tested various scenarios and tried to match race condition and failed, all is reliable on test rig, pulling into master and will reopen if further issues observed in the wild.