DRAFT: Call Handler when failure occurs, update threading strategy

someoneAnyone / Nightscouter

An Native iOS app for displaying Nightscout website data.

MIT License

19 stars 25 forks source link

DRAFT: Call Handler when failure occurs, update threading strategy #47

Closed rodericj closed 8 years ago

rodericj commented 8 years ago

Just a draft PR to get the conversation started. See comments below.

rodericj commented 8 years ago

The comment formatting is optional and I can put it back the way it was if you need it that way. I can also break it into different commits too.

Anyway, I'd love it if @someoneAnyone would take a look at the changes. Let's start a discussion about if this might destroy some functionality. Mostly this was just a cleanup.

someoneAnyone commented 8 years ago

I'm downloading the PR now. I throw it on a phone and test tomorrow.

rodericj commented 8 years ago

@someoneAnyone checkout #49. I closed this one and created a new one pointing to dev. Let me know if this works for you or if you actually need me to check out dev and apply the changes. It seems that the new one is merge-able so I think we are ok.