search

someshkar / covid19india-cluster

:microscope: Covid19 India Cluster Graph
https://cluster.covid19india.org
MIT License
989 stars 654 forks source link

Patient with id 251042 has no state/district/city attached so throwin… #154

Closed KSaiVinod closed 4 years ago

KSaiVinod commented 4 years ago

…g error while checking for city/state filter, Fixed by checking no state in getCityDistrictOrState method and same checking in addCities method

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/someshkar/covid19india-network/ip3gbhubz ✅ Preview: https://covid19india-network-git-fork-saivinod440-master.someshkar.now.sh

KSaiVinod commented 4 years ago

251047,251048,251049 these ids are not having any state info inorder to handle if no state the above fix will work without any code break which is happening now

sibeshkar commented 4 years ago

Thanks for pushing this. The error still seems to be happening for the travel filter. Can add a fix to that in this PR?

Uncaught Error: Object argument required.

sibeshkar commented 4 years ago

Ignore, I think travel filter is problem with the NLP api. Thanks for the fix.

KSaiVinod commented 4 years ago

Just now checked with travel as well this seems to be happening with travel if place_attributes object is not present currently we are checking if it's not null but if it is undefined it'll again block the code flow even if we are getting data from NLP API. I'll be fixing and create a pull request within an hour :)