somnathrakshit / geograpy3

Extract place names from a URL or text, and add context to those names -- for example distinguishing between a country, region or city.
https://geograpy3.readthedocs.io
Apache License 2.0
124 stars 12 forks source link

Fix downloaders for NLTK and DBs #66

Closed somnathrakshit closed 2 years ago

somnathrakshit commented 2 years ago

Based on this comment: https://github.com/somnathrakshit/geograpy3/issues/59#issuecomment-1140094639

  1. Fixing NLTK downloader: Downloading NLTK libraries using setup.py instead of having a separate python file which is run using the scripts keyword (which does not work in Windows) in setup.py.
  2. Fixing DB downloader: To download the DBs when this package is installed, we can similarly move the download and extract code to setup.py. Current code does not work since there is a permission error when we try to extract the gzip file.