search

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

Get rid of container usage from FilterFactory #4982

Closed soullivaneuh closed 3 years ago

soullivaneuh commented 6 years ago

Ref: https://github.com/sonata-project/SonataAdminBundle/blob/405c5b2e0fb49d070b73783631352bf57f5ae5fa/src/Filter/FilterFactory.php

Why? Because it's ugly. That's why.

Deprecate it on 3.x, remove it on master.

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

VincentLanglet commented 3 years ago

Close by https://github.com/sonata-project/SonataAdminBundle/issues/6963, I think (cc @franmomu)