search

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

AdminLTE 3 implementation #5597

Closed muspelheim closed 3 years ago

muspelheim commented 5 years ago

Feature Request

Hi, are you planned to implement AdminLTE 3? it looks better than 2 and seems modern

https://adminlte.io/themes/dev/AdminLTE/index.html

OskarStark commented 5 years ago

No plans yet, but we would highly appreciate it 😍 @silasjoisten is currently working on implementing Webpack Encore in https://github.com/sonata-project/SonataAdminBundle/pull/5461

This should be done afterwards, maybe you can support him

ElectricMaxxx commented 5 years ago

Yeess. Just a quick win for now.

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

wbloszyk commented 4 years ago

Please reopen this issue. I will update AdminLte.

@silasjoisten Do you need help with Webpack? Are you still working on it?

wbloszyk commented 4 years ago

@OskarStark Also can You create new temporary branch from master? I think better way for review will be create seperate branch, adding changes in atomic commits and after all rebase it to master branch.

OskarStark commented 4 years ago

Sure I can, but we should merge Webpack integration first, should we?

wbloszyk commented 4 years ago

It will be nice if webpack is finished. If not i can update AdminLte(commits: upgrade vendor, update templates...) but after rebase result will be the same.

wbloszyk commented 4 years ago

@OskarStark We can push both features to temperary branch and after work done rebase it and marge to master.

@sonata-project/contributors Like We wrote here:

@OskarStark Also can You create new temporary branch from master? I think better way for review will be create seperate branch, adding changes in atomic commits and after all rebase it to master branch.

Sure I can, but we should merge Webpack integration first, should we?

I check webpack. Last update was in 1 march 2020. I decide to help(or finish it) for @silasjoisten. Can i split it and push as atomic commits? Mark @silasjoisten as co-author will be enough? I dont wanna stealing his work.

Also today I should finish integrate AdminLTE 3 but is should be update after webpack to avoid unnesessery adding vendors.

OskarStark commented 4 years ago

@silasjoisten can you add @wbloszyk as maintainer to your fork?

github-actions[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

VincentLanglet commented 3 years ago

Will close in favor of the discussion in https://github.com/sonata-project/SonataAdminBundle/issues/7156