search

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

The `case_sensitive` option of the global search rely on the persistence bundle #7274

Closed VincentLanglet closed 3 years ago

VincentLanglet commented 3 years ago

Looking at the doc https://symfony.com/doc/current/bundles/SonataAdminBundle/reference/search.html#case-sensitive-insensitive I found a case_sensitive option exists for the global search.

It's used in two places.

But I would say it rely on the way the StringFilter handle the option like in the doctrineORMAdminBundle. https://github.com/sonata-project/SonataDoctrineORMAdminBundle/blob/3.x/src/Filter/StringFilter.php#L160

In the doctrineMongoAdminBundle, there is no case_sensitive. In the doctrineORMAdminBundle, the option was deprecated in 3.x (cc @phansys) and removed in 4.0.

What can we do about this ? Should we deprecate this option ? @sonata-project/contributors.

VincentLanglet commented 3 years ago

Deprecated in https://github.com/sonata-project/SonataAdminBundle/pull/7275