search

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

Default Logged-in user button is empty #7322

Closed Jean-Gian closed 2 years ago

Jean-Gian commented 3 years ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle 4.0.0-alpha-2 4.0.0-alpha-2 The missing Symfony Admin Generator sonata-project/block-bundle 4.6.0 4.6.0 Symfony SonataBlockBundle sonata-project/cache 2.1.1 2.1.1 Cache library sonata-project/doctrine-extensions 1.13.0 1.13.0 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 4.0.0-alpha-2 4.0.0-alpha-2 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.7.0 2.7.0 Lightweight Exporter library sonata-project/form-extensions 1.9.0 1.9.0 Symfony form extensions sonata-project/twig-extensions 1.6.0 1.6.0 Sonata twig extensions ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/acl-bundle v2.1.0 v2.1.0 Symfony AclBundle symfony/apache-pack v1.0.1 v1.0.1 A pack for Apache support in Symfony symfony/asset v5.3.2 v5.3.2 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files symfony/browser-kit v5.3.0 v5.3.0 Simulates the behavior of a web browser, allowing you to make requests, click on links and submit forms programmatically symfony/cache v5.3.3 v5.3.3 Provides an extended PSR-6, PSR-16 (and tags) implementation symfony/cache-contracts v2.4.0 v2.4.0 Generic abstractions related to caching symfony/config v5.3.3 v5.3.3 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v5.3.2 v5.3.2 Eases the creation of beautiful and testable command line interfaces symfony/css-selector v5.3.0 v5.3.0 Converts CSS selectors to XPath expressions symfony/debug-bundle v5.3.0 v5.3.0 Provides a tight integration of the Symfony Debug component into the Symfony full-stack framework symfony/dependency-injection v5.3.3 v5.3.3 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v2.4.0 v2.4.0 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v5.3.3 v5.3.3 Provides integration for Doctrine with various Symfony components symfony/dom-crawler v5.3.0 v5.3.0 Eases DOM navigation for HTML and XML documents symfony/dotenv v5.3.0 v5.3.0 Registers environment variables from a .env file symfony/error-handler v5.3.3 v5.3.3 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v5.3.0 v5.3.0 Provides tools that allow your application components to communicate with each other by dispatching events and listening to them symfony/event-dispatcher-contracts v2.4.0 v2.4.0 Generic abstractions related to dispatching event symfony/expression-language v5.3.0 v5.3.0 Provides an engine that can compile and evaluate expressions symfony/filesystem v5.3.3 v5.3.3 Provides basic utilities for the filesystem symfony/finder v5.3.0 v5.3.0 Finds files and directories via an intuitive fluent interface symfony/flex v1.13.3 v1.13.3 Composer plugin for Symfony symfony/form v5.3.3 v5.3.3 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v5.3.3 v5.3.3 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/http-client v5.3.3 v5.3.3 Provides powerful methods to fetch HTTP resources synchronously or asynchronously symfony/http-client-contracts v2.4.0 v2.4.0 Generic abstractions related to HTTP clients symfony/http-foundation v5.3.3 v5.3.3 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v5.3.3 v5.3.3 Provides a structured process for converting a Request into a Response symfony/intl v5.3.0 v5.3.0 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library symfony/lock v5.3.2 v5.3.2 Creates and manages locks, a mechanism to provide exclusive access to a shared resource symfony/mailer v5.3.3 v5.3.3 Helps sending emails symfony/mailgun-mailer v5.3.0 v5.3.0 Symfony Mailgun Mailer Bridge symfony/maker-bundle v1.33.0 v1.33.0 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about writing boilerplate code. symfony/mime v5.3.2 v5.3.2 Allows manipulating MIME messages symfony/monolog-bridge v5.3.3 v5.3.3 Provides integration for Monolog with various Symfony components symfony/monolog-bundle v3.7.0 v3.7.0 Symfony MonologBundle symfony/options-resolver v5.3.0 v5.3.0 Provides an improved replacement for the array_replace PHP function symfony/orm-pack v2.1.0 v2.1.0 A pack for the Doctrine ORM symfony/password-hasher v5.3.3 v5.3.3 Provides password hashing utilities symfony/phpunit-bridge v5.3.3 v5.3.3 Provides utilities for PHPUnit, especially user deprecation notices management symfony/polyfill-intl-grapheme v1.23.0 v1.23.0 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.23.0 v1.23.0 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.23.0 v1.23.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.23.0 v1.23.0 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.23.0 v1.23.0 Symfony polyfill for the Mbstring extension symfony/polyfill-php72 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions symfony/polyfill-php73 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/polyfill-php81 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions symfony/process v5.3.2 v5.3.2 Executes commands in sub-processes symfony/property-access v5.3.0 v5.3.0 Provides functions to read and write from/to an object or array using a simple string notation symfony/property-info v5.3.1 v5.3.1 Extracts information about PHP class' properties using metadata of popular sources symfony/proxy-manager-bridge v5.3.0 v5.3.0 Provides integration for ProxyManager with various Symfony components symfony/rate-limiter v5.3.0 v5.3.0 Provides a Token Bucket implementation to rate limit input and output in your application symfony/routing v5.3.0 v5.3.0 Maps an HTTP request to a set of configuration variables symfony/security-acl v3.1.2 v3.1.2 Symfony Security Component - ACL (Access Control List) symfony/security-bundle v5.3.3 v5.3.3 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/security-core v5.3.3 v5.3.3 Symfony Security Component - Core Library symfony/security-csrf v5.3.3 v5.3.3 Symfony Security Component - CSRF Library symfony/security-guard v5.3.0 v5.3.0 Symfony Security Component - Guard symfony/security-http v5.3.3 v5.3.3 Symfony Security Component - HTTP Integration symfony/serializer v5.3.2 v5.3.2 Handles serializing and deserializing data structures, including object graphs, into array structures or other formats like XML and JSON. symfony/serializer-pack v1.0.4 v1.0.4 A pack for the Symfony serializer symfony/service-contracts v2.4.0 v2.4.0 Generic abstractions related to writing services symfony/stopwatch v5.3.0 v5.3.0 Provides a way to profile code symfony/string v5.3.3 v5.3.3 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way symfony/swiftmailer-bundle v3.5.2 v3.5.2 Symfony SwiftmailerBundle symfony/templating v5.3.0 v5.3.0 Provides all the tools needed to build any kind of template system symfony/translation v5.3.3 v5.3.3 Provides tools to internationalize your application symfony/translation-contracts v2.4.0 v2.4.0 Generic abstractions related to translation symfony/twig-bridge v5.3.3 v5.3.3 Provides integration for Twig with various Symfony components symfony/twig-bundle v5.3.3 v5.3.3 Provides a tight integration of Twig into the Symfony full-stack framework symfony/validator v5.3.3 v5.3.3 Provides tools to validate values symfony/var-dumper v5.3.3 v5.3.3 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v5.3.3 v5.3.3 Allows exporting any serializable PHP data structure to plain PHP code symfony/web-link v5.3.3 v5.3.3 Manages links between resources symfony/web-profiler-bundle v5.3.2 v5.3.2 Provides a development tool that gives detailed information about the execution of any request symfony/webpack-encore-bundle v1.12.0 v1.12.0 Integration with your Symfony app & Webpack Encore! symfony/yaml v5.3.3 v5.3.3 Loads and dumps YAML files ```

PHP version

$ php -v
PHP 7.4.18 (cli) (built: May  3 2021 11:26:48) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.18, Copyright (c), by Zend Technologies

Subject

When clicking on the logged-in user button on the top-right the menu (which should contain the logout button) nothing happens Screenshot 2021-07-13 at 18 00 11

Minimal repository with the bug

4.x

Steps to reproduce

Click on the button

Expected results

Screenshot 2021-07-13 at 18 08 00

Actual results

Screenshot 2021-07-13 at 18 09 52

VincentLanglet commented 3 years ago

Did you tried to use older v4 version to find the commit which broke this ?

The screen shot you gave is not related to the AdminBundle. I assume it's from https://github.com/sonata-project/SonataUserBundle/blob/4.x/src/Resources/views/Admin/Core/user_block.html.twig

The SonataUserBundle is not compatible with SonataAdminBundle. Did you remove the bundle when upgrading to the v4 ?

Jean-Gian commented 3 years ago

Sorry for the confusion. Yes i did delete the SonataUserBundle (and implemented the user myself), so i can't understand why it's showing it. I'll investigate further, if you have suggestions please let me know.

I haven't tried other versions, i will

Jean-Gian commented 3 years ago

I see what's happening. It's this template being called, not doing anything: https://github.com/sonata-project/SonataAdminBundle/blob/4.0.0-alpha-2/src/Resources/views/Core/user_block.html.twig

VincentLanglet commented 3 years ago

I see what's happening. It's this template being called, not doing anything: https://github.com/sonata-project/SonataAdminBundle/blob/4.0.0-alpha-2/src/Resources/views/Core/user_block.html.twig

It's already the case in 3.x.

As explained here: https://github.com/sonata-project/SonataAdminBundle/blob/fabd5c70421d51eccf777c2c70a908240efe7854/docs/reference/security.rst#user-management, if the bundle detect SonataUserBundle, it use the template for SonataUserBundle. If not, it render an empty template. So this is an expected behavior and not related to Sonata 4.

The only thing we could do is to provide a better default template. Do you want to try providing one ?

Jean-Gian commented 3 years ago

Yes, I fully understand now. I think at least the logout button should be present in user_block.html.twig I'm overriding the template doing something similar to what the user bundle did. Once done i can provide it

VincentLanglet commented 3 years ago

Hi @Jean-ita, have you got something interesting ? :)

Jean-Gian commented 3 years ago

I do but i'm away until the 23rd, i can update you after that

VincentLanglet commented 3 years ago

I do but i'm away until the 23rd, i can update you after that

Friendly ping @Jean-ita :)

Jean-Gian commented 3 years ago

Sorry, nothing yet