search

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

GUI glitches with doctrine embadded entity #7442

Closed skydiablo closed 3 years ago

skydiablo commented 3 years ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle 4.0.0-rc.1 4.0.0-rc.1 The missing Symfony Admin Generator sonata-project/block-bundle 4.7.0 4.7.0 Symfony SonataBlockBundle sonata-project/cache 2.2.0 2.2.0 Cache library sonata-project/doctrine-extensions 1.x-dev f60519e 1.x-dev f60519e Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle dev-master f5ae38e dev-master f5ae38e Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.7.0 2.7.0 Lightweight Exporter library sonata-project/form-extensions 1.9.0 1.9.0 Symfony form extensions sonata-project/twig-extensions 1.7.0 1.7.0 Sonata twig extensions ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/asset v5.3.4 v5.3.4 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files symfony/cache v5.3.4 v5.3.4 Provides an extended PSR-6, PSR-16 (and tags) implementation symfony/cache-contracts v2.4.0 v2.4.0 Generic abstractions related to caching symfony/config v5.3.4 v5.3.4 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v5.3.6 v5.3.6 Eases the creation of beautiful and testable command line interfaces symfony/dependency-injection v5.3.4 v5.3.4 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v2.4.0 v2.4.0 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v5.3.4 v5.3.4 Provides integration for Doctrine with various Symfony components symfony/dom-crawler v5.3.4 v5.3.4 Eases DOM navigation for HTML and XML documents symfony/dotenv v5.3.6 v5.3.6 Registers environment variables from a .env file symfony/error-handler v5.3.4 v5.3.4 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v5.3.4 v5.3.4 Provides tools that allow your application components to communicate with each other by dispatching events and listening to them symfony/event-dispatcher-contracts v2.4.0 v2.4.0 Generic abstractions related to dispatching event symfony/expression-language v5.3.4 v5.3.4 Provides an engine that can compile and evaluate expressions symfony/filesystem v5.3.4 v5.3.4 Provides basic utilities for the filesystem symfony/finder v5.3.4 v5.3.4 Finds files and directories via an intuitive fluent interface symfony/flex v1.13.4 v1.13.4 Composer plugin for Symfony symfony/form v5.3.4 v5.3.4 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v5.3.4 v5.3.4 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/http-client v5.3.4 v5.3.4 Provides powerful methods to fetch HTTP resources synchronously or asynchronously symfony/http-client-contracts v2.4.0 v2.4.0 Generic abstractions related to HTTP clients symfony/http-foundation v5.3.6 v5.3.6 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v5.3.6 v5.3.6 Provides a structured process for converting a Request into a Response symfony/intl v5.3.4 v5.3.4 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library symfony/mailer v5.3.4 v5.3.4 Helps sending emails symfony/maker-bundle v1.33.0 v1.33.0 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about writing boilerplate code. symfony/mime v5.3.4 v5.3.4 Allows manipulating MIME messages symfony/monolog-bridge v5.3.4 v5.3.4 Provides integration for Monolog with various Symfony components symfony/monolog-bundle v3.7.0 v3.7.0 Symfony MonologBundle symfony/notifier v5.3.4 v5.3.4 Sends notifications via one or more channels (email, SMS, ...) symfony/options-resolver v5.3.4 v5.3.4 Provides an improved replacement for the array_replace PHP function symfony/password-hasher v5.3.4 v5.3.4 Provides password hashing utilities symfony/polyfill-intl-grapheme v1.23.1 v1.23.1 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.23.0 v1.23.0 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.23.0 v1.23.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.23.0 v1.23.0 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.23.1 v1.23.1 Symfony polyfill for the Mbstring extension symfony/polyfill-php72 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions symfony/polyfill-php73 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.23.1 v1.23.1 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/polyfill-php81 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions symfony/process v5.3.4 v5.3.4 Executes commands in sub-processes symfony/profiler-pack v1.0.5 v1.0.5 A pack for the Symfony web profiler symfony/property-access v5.3.4 v5.3.4 Provides functions to read and write from/to an object or array using a simple string notation symfony/property-info v5.3.4 v5.3.4 Extracts information about PHP class' properties using metadata of popular sources symfony/proxy-manager-bridge v5.3.4 v5.3.4 Provides integration for ProxyManager with various Symfony components symfony/routing v5.3.4 v5.3.4 Maps an HTTP request to a set of configuration variables symfony/security-acl v3.2.0 v3.2.0 Symfony Security Component - ACL (Access Control List) symfony/security-bundle v5.3.4 v5.3.4 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/security-core v5.3.6 v5.3.6 Symfony Security Component - Core Library symfony/security-csrf v5.3.4 v5.3.4 Symfony Security Component - CSRF Library symfony/security-guard v5.3.4 v5.3.4 Symfony Security Component - Guard symfony/security-http v5.3.6 v5.3.6 Symfony Security Component - HTTP Integration symfony/serializer v5.3.4 v5.3.4 Handles serializing and deserializing data structures, including object graphs, into array structures or other formats like XML and JSON. symfony/service-contracts v2.4.0 v2.4.0 Generic abstractions related to writing services symfony/stopwatch v5.3.4 v5.3.4 Provides a way to profile code symfony/string v5.3.3 v5.3.3 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way symfony/templating v5.3.4 v5.3.4 Provides all the tools needed to build any kind of template system symfony/translation v5.3.4 v5.3.4 Provides tools to internationalize your application symfony/translation-contracts v2.4.0 v2.4.0 Generic abstractions related to translation symfony/twig-bridge v5.3.4 v5.3.4 Provides integration for Twig with various Symfony components symfony/twig-bundle v5.3.4 v5.3.4 Provides a tight integration of Twig into the Symfony full-stack framework symfony/validator v5.3.6 v5.3.6 Provides tools to validate values symfony/var-dumper v5.3.6 v5.3.6 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v5.3.4 v5.3.4 Allows exporting any serializable PHP data structure to plain PHP code symfony/web-link v5.3.4 v5.3.4 Manages links between resources symfony/web-profiler-bundle v5.3.5 v5.3.5 Provides a development tool that gives detailed information about the execution of any request symfony/web-server-bundle v4.4.27 v4.4.27 Provides commands for running applications using the PHP built-in web server symfony/yaml v5.3.6 v5.3.6 Loads and dumps YAML files ```

PHP version

$ php -v
PHP 7.4.3 (cli) (built: Jul  5 2021 15:13:35) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with the ionCube PHP Loader + ionCube24 v10.4.5, Copyright (c) 2002-2020, by ionCube Ltd.
    with Zend OPcache v7.4.3, Copyright (c), by Zend Technologies
    with Xdebug v2.9.2, Copyright (c) 2002-2020, by Derick Rethans

Subject

Steps to reproduce

create an admin dashboard with:

    protected function configureFormFields(FormMapper $form): void
    {

        $form
            ->add(/* some properties */)
        ->end();
        $form->with('GPS')
            ->add('gps.latitude', NumberType::class, ['label' => 'Latitude', 'scale' => 6])
            ->add('gps.longitude', NumberType::class, ['label' => 'Longitude', 'scale' => 6])
        ->end();

...

the given sub properties (gps.x, gps.y) are virtual properties from an embedded doctrine entity.

Expected results

just an simple admin panel with headline "GPS" and two properties (lat/lon)

Actual results

the two given proerties are outside the "GPS" frame?! there are no reale errors, just this GUI problem :(

image

panels they are followed by the GPS panel will be injected between the properties and the empty GPS panel?

image

regards, volker.

VincentLanglet commented 3 years ago

I should release a RC-2 because I already fix this. Please use the the latest commit and tell me if it's ok for you ? @skydiablo

skydiablo commented 3 years ago

hm, sry ... but maybe you can add an new rc-2 release... if i try to set the last commit:

"sonata-project/admin-bundle": "dev-master#7130558ca19596a5b9b86f6c8f52a52f404a85f6",

it ends in an dependencies hell :(

  Problem 1
    - sonata-project/doctrine-orm-admin-bundle[4.0.0-rc.1, ..., 4.x-dev] require sonata-project/admin-bundle ^4.0@rc -> found sonata-project/admin-bundle[4.0.0-alpha-1, 4.0.0-alpha-2, 4.0.0-rc.1, 4.x-dev] but it conflicts with your root composer.json require (dev-master#7130558ca19596a5b9b86f6c8f52a52f404a85f6).
    - sonata-project/doctrine-orm-admin-bundle 4.0.0-alpha-1 requires sonata-project/admin-bundle 4.0.0-alpha-1 -> found sonata-project/admin-bundle[4.0.0-alpha-1] but it conflicts with your root composer.json require (dev-master#7130558ca19596a5b9b86f6c8f52a52f404a85f6).
    - sonata-project/doctrine-orm-admin-bundle 4.0.0-alpha-2 requires sonata-project/admin-bundle ^4.0@dev -> found sonata-project/admin-bundle[4.0.0-alpha-1, 4.0.0-alpha-2, 4.0.0-rc.1, 4.x-dev] but it conflicts with your root composer.json require (dev-master#7130558ca19596a5b9b86f6c8f52a52f404a85f6).
    - Root composer.json requires sonata-project/doctrine-orm-admin-bundle ^4.0 -> satisfiable by sonata-project/doctrine-orm-admin-bundle[4.0.0-alpha-1, 4.0.0-alpha-2, 4.0.0-rc.1, 4.x-dev].
VincentLanglet commented 3 years ago 
        "sonata-project/admin-bundle": "4.x-dev",
        "sonata-project/doctrine-orm-admin-bundle": "4.0.0-rc.1",

Works fine for me, but sure I'll soon release rc.2

skydiablo commented 3 years ago

hm. okay... just using the alias 4.x-dev solve thge problem ;) thx :D my GUI is fixed, thx!