Argument 2 passed to Sonata\AdminBundle\Form\DataTransformer\ModelToIdTransformer::__construct() must be of the type string

Pasttaga commented 3 years ago

Hello there,

Environment

Sonata Package

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle 4.0.0 4.0.0 The missing Symfony Admin Generator sonata-project/block-bundle 4.7.0 4.7.0 Symfony SonataBlockBundle sonata-project/cache 2.2.0 2.2.0 Cache library sonata-project/doctrine-extensions 1.13.1 1.13.1 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 4.0.0 4.0.0 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.7.0 2.8.0 Lightweight Exporter library sonata-project/form-extensions 1.10.0 1.11.0 Symfony form extensions sonata-project/intl-bundle 2.10.2 2.10.2 Symfony SonataIntlBundle sonata-project/twig-extensions 1.8.0 1.9.0 Sonata twig extensions ```

Symfony packages

``` symfony/amqp-messenger v5.3.7 v5.3.7 Symfony AMQP extension Messenger Bridge symfony/asset v5.3.4 v5.3.4 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image f... symfony/browser-kit v5.3.4 v5.3.4 Simulates the behavior of a web browser, allowing you to make requests, click on links and submit forms p... symfony/cache v5.3.7 v5.3.7 Provides an extended PSR-6, PSR-16 (and tags) implementation symfony/cache-contracts v2.4.0 v2.4.0 Generic abstractions related to caching symfony/config v5.3.4 v5.3.4 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v5.3.7 v5.3.7 Eases the creation of beautiful and testable command line interfaces symfony/contracts v1.1.0 v2.4.0 A set of abstractions extracted out of the Symfony components symfony/css-selector v5.3.4 v5.3.4 Converts CSS selectors to XPath expressions symfony/debug-bundle v5.3.4 v5.3.4 Provides a tight integration of the Symfony Debug component into the Symfony full-stack framework symfony/dependency-injection v5.3.7 v5.3.7 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v2.4.0 v2.4.0 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v5.3.7 v5.3.7 Provides integration for Doctrine with various Symfony components symfony/doctrine-messenger v5.3.7 v5.3.7 Symfony Doctrine Messenger Bridge symfony/dom-crawler v5.3.7 v5.3.7 Eases DOM navigation for HTML and XML documents symfony/dotenv v5.3.7 v5.3.7 Registers environment variables from a .env file symfony/error-handler v5.3.7 v5.3.7 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v5.3.7 v5.3.7 Provides tools that allow your application components to communicate with each other by dispatching event... symfony/event-dispatcher-contracts v2.4.0 v2.4.0 Generic abstractions related to dispatching event symfony/expression-language v5.3.7 v5.3.7 Provides an engine that can compile and evaluate expressions symfony/filesystem v5.3.4 v5.3.4 Provides basic utilities for the filesystem symfony/finder v5.3.7 v5.3.7 Finds files and directories via an intuitive fluent interface symfony/flex v1.15.4 v1.15.4 Composer plugin for Symfony symfony/form v5.3.7 v5.3.7 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v5.3.7 v5.3.7 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/http-client v5.3.7 v5.3.7 Provides powerful methods to fetch HTTP resources synchronously or asynchronously symfony/http-client-contracts v2.4.0 v2.4.0 Generic abstractions related to HTTP clients symfony/http-foundation v5.3.7 v5.3.7 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v5.3.7 v5.3.7 Provides a structured process for converting a Request into a Response symfony/intl v5.3.7 v5.3.7 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library symfony/lock v5.3.4 v5.3.4 Creates and manages locks, a mechanism to provide exclusive access to a shared resource symfony/mailer v5.3.4 v5.3.4 Helps sending emails symfony/maker-bundle v1.33.0 v1.33.0 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forge... symfony/messenger v5.3.7 v5.3.7 Helps applications send and receive messages to/from other applications or via message queues symfony/mime v5.3.7 v5.3.7 Allows manipulating MIME messages symfony/monolog-bridge v5.3.7 v5.3.7 Provides integration for Monolog with various Symfony components symfony/monolog-bundle v3.7.0 v3.7.0 Symfony MonologBundle symfony/options-resolver v5.3.7 v5.3.7 Provides an improved replacement for the array_replace PHP function symfony/password-hasher v5.3.7 v5.3.7 Provides password hashing utilities symfony/phpunit-bridge v5.3.7 v5.3.7 Provides utilities for PHPUnit, especially user deprecation notices management symfony/polyfill-apcu v1.23.0 v1.23.0 Symfony polyfill backporting apcu_* functions to lower PHP versions symfony/polyfill-ctype v1.23.0 v1.23.0 Symfony polyfill for ctype functions symfony/polyfill-iconv v1.23.0 v1.23.0 Symfony polyfill for the Iconv extension symfony/polyfill-intl-grapheme v1.23.1 v1.23.1 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.23.0 v1.23.0 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.23.0 v1.23.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.23.0 v1.23.0 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.23.1 v1.23.1 Symfony polyfill for the Mbstring extension symfony/polyfill-php72 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions symfony/polyfill-php73 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.23.1 v1.23.1 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/polyfill-php81 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions symfony/polyfill-uuid v1.23.0 v1.23.0 Symfony polyfill for uuid functions symfony/process v5.3.7 v5.3.7 Executes commands in sub-processes symfony/property-access v5.3.7 v5.3.7 Provides functions to read and write from/to an object or array using a simple string notation symfony/property-info v5.3.7 v5.3.7 Extracts information about PHP class' properties using metadata of popular sources symfony/proxy-manager-bridge v5.3.4 v5.3.4 Provides integration for ProxyManager with various Symfony components symfony/psr-http-message-bridge v2.1.1 v2.1.1 PSR HTTP message bridge symfony/redis-messenger v5.3.7 v5.3.7 Symfony Redis extension Messenger Bridge symfony/routing v5.3.7 v5.3.7 Maps an HTTP request to a set of configuration variables symfony/security-acl v3.2.0 v3.2.0 Symfony Security Component - ACL (Access Control List) symfony/security-bundle v5.3.7 v5.3.7 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/security-core v5.3.7 v5.3.7 Symfony Security Component - Core Library symfony/security-csrf v5.3.4 v5.3.4 Symfony Security Component - CSRF Library symfony/security-guard v5.3.7 v5.3.7 Symfony Security Component - Guard symfony/security-http v5.3.7 v5.3.7 Symfony Security Component - HTTP Integration symfony/serializer v5.3.4 v5.3.4 Handles serializing and deserializing data structures, including object graphs, into array structures or ... symfony/service-contracts v2.4.0 v2.4.0 Generic abstractions related to writing services symfony/stopwatch v5.3.4 v5.3.4 Provides a way to profile code symfony/string v5.3.7 v5.3.7 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters ... symfony/swiftmailer-bundle v3.5.2 v3.5.2 Symfony SwiftmailerBundle symfony/templating v5.3.7 v5.3.7 Provides all the tools needed to build any kind of template system symfony/translation v5.3.7 v5.3.7 Provides tools to internationalize your application symfony/translation-contracts v2.4.0 v2.4.0 Generic abstractions related to translation symfony/twig-bridge v5.3.7 v5.3.7 Provides integration for Twig with various Symfony components symfony/twig-bundle v5.3.4 v5.3.4 Provides a tight integration of Twig into the Symfony full-stack framework symfony/validator v5.3.7 v5.3.7 Provides tools to validate values symfony/var-dumper v5.3.7 v5.3.7 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v5.3.7 v5.3.7 Allows exporting any serializable PHP data structure to plain PHP code symfony/web-link v5.3.4 v5.3.4 Manages links between resources symfony/web-profiler-bundle v5.3.5 v5.3.5 Provides a development tool that gives detailed information about the execution of any request symfony/workflow v5.3.4 v5.3.4 Provides tools for managing a workflow or finite state machine symfony/yaml v5.3.6 v5.3.6 Loads and dumps YAML files ```

$ php -v
PHP 7.4.23 (cli) (built: Sep  3 2021 17:58:14) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies

Subject I try to link 2 admin with method addChild. When i list parent elements, no problem !

But when i want to list child elements of the parent on my route : /admin/app/setting/document/6/questiongroup/list

I have this error : Argument 2 passed to Sonata\AdminBundle\Form\DataTransformer\ModelToIdTransformer::__construct() must be of the type string, null given, called in /app/vendor/sonata-project/admin-bundle/src/Form/Type/ModelHiddenType.php on line 36

I'm not override any controller see bellow my admin service declaration:

services:
  App\SonataAdmin\DocumentAdmin:
    tags:
      - { name: sonata.admin, manager_type: orm }
    arguments: [~, App\Setting\Entity\Document, ~]
    calls:
      - [ addChild, ['@App\SonataAdmin\QuestionGroupAdmin', 'questionGroups' ] ]

  App\SonataAdmin\QuestionGroupAdmin:
    tags:
      - { name: sonata.admin, manager_type: orm }
    arguments: [~, App\Setting\Entity\QuestionGroup, ~]

I follow the documentation : https://docs.sonata-project.org/projects/SonataAdminBundle/en/4.x/reference/child_admin/?highlight=addChild

And have no errors with previous version of sonata with symfony 4.4

Stack Trace

``` in vendor/sonata-project/admin-bundle/src/Form/DataTransformer/ModelToIdTransformer.php (line 43) in vendor/sonata-project/admin-bundle/src/Form/Type/ModelHiddenType.php -> __construct (line 36) in vendor/symfony/form/ResolvedFormType.php -> buildForm (line 131) in vendor/symfony/form/Extension/DataCollector/Proxy/ResolvedTypeDataCollectorProxy.php -> buildForm (line 95) in vendor/symfony/form/FormFactory.php -> buildForm (line 73) in vendor/symfony/form/FormBuilder.php -> createNamedBuilder (line 95) in vendor/symfony/form/FormBuilder.php -> create (line 247) in vendor/symfony/form/FormBuilder.php -> resolveChildren (line 197) in vendor/symfony/form/FormBuilder.php -> getForm (line 203) in vendor/sonata-project/admin-bundle/src/Datagrid/Datagrid.php -> getForm (line 386) in vendor/sonata-project/admin-bundle/src/Datagrid/Datagrid.php -> buildForm (line 237) in vendor/sonata-project/admin-bundle/src/Controller/CRUDController.php -> getForm (line 122) in vendor/symfony/http-kernel/HttpKernel.php -> listAction (line 156) in vendor/symfony/http-kernel/HttpKernel.php -> handleRaw (line 78) in vendor/symfony/http-kernel/Kernel.php -> handle (line 199) ``` Thanks for your help

dmaicher commented 3 years ago

I'm not using child admins on any of my projects. @VincentLanglet are you using this by any chance?

Anyway a small reproducer project would help to debug this.

VincentLanglet commented 3 years ago

I'm not using child admins on any of my projects. @VincentLanglet are you using this by any chance?

Yes I do, without any error.

The example give

App\Admin\PlaylistAdmin:
    calls:
        - [addChild, ['@App\Admin\VideoAdmin', 'playlist']]

So you should use

[ addChild, ['@App\SonataAdmin\QuestionGroupAdmin', 'document' ] ]

maybe depending on the way your relation are made

Anyway a small reproducer project would help to debug this.

It would help indeed.

VincentLanglet commented 3 years ago

The ModelHiddenType is using null as default value for the modelManager and the className option but it's not allowed in the constructor.

It could be better to make those options required to improve the error message.

We might need to look at the persistence bundle to understand why those options are not correctly set but it might be related to a config error

Pasttaga commented 3 years ago

Thinks for your help @VincentLanglet & @dmaicher,

I misunderstood the doc, i used the child field on addChild method instead of parent one.

Sorry for inconvenience, continue your great job.

jordisala1991 commented 3 years ago

The ModelHiddenType is using null as default value for the modelManager and the className option but it's not allowed in the constructor.

It could be better to make those options required to improve the error message.

We might need to look at the persistence bundle to understand why those options are not correctly set but it might be related to a config error

Yep, we should try to catch that error before it gets to the constructor of that class, so we can show a better error message to the user.

sonata-project / SonataAdminBundle

Argument 2 passed to Sonata\AdminBundle\Form\DataTransformer\ModelToIdTransformer::__construct() must be of the type string #7505