Related entity has not updated

[eerison]

Environment

Sonata packages

show

``` sonata-project/admin-bundle 4.8.1 4.8.1 The missing Symfony Admin Generator sonata-project/block-bundle 4.9.1 4.9.1 Symfony SonataBlockBundle sonata-project/cache 2.2.0 2.2.0 Cache library sonata-project/doctrine-extensions 1.16.0 1.16.0 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 4.2.3 4.2.3 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.10.1 2.11.0 Lightweight Exporter library sonata-project/form-extensions 1.12.4 1.13.0 Symfony form extensions sonata-project/twig-extensions 1.9.1 1.9.1 Sonata twig extensions ```

Symfony packages

show

``` symfony/asset v6.0.3 v6.0.3 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files symfony/cache v6.0.3 v6.0.3 Provides an extended PSR-6, PSR-16 (and tags) implementation symfony/cache-contracts v3.0.0 v3.0.0 Generic abstractions related to caching symfony/config v6.0.3 v6.0.3 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v6.0.3 v6.0.3 Eases the creation of beautiful and testable command line interfaces symfony/debug-bundle v6.0.3 v6.0.3 Provides a tight integration of the Symfony VarDumper component and the ServerLogCommand from MonologBridge into the Symfony full-stack framework symfony/dependency-injection v6.0.3 v6.0.3 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v3.0.0 v3.0.0 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v6.0.3 v6.0.3 Provides integration for Doctrine with various Symfony components symfony/doctrine-messenger v6.0.3 v6.0.3 Symfony Doctrine Messenger Bridge symfony/dotenv v6.0.3 v6.0.3 Registers environment variables from a .env file symfony/error-handler v6.0.3 v6.0.3 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v6.0.3 v6.0.3 Provides tools that allow your application components to communicate with each other by dispatching events and listening to them symfony/event-dispatcher-contracts v3.0.0 v3.0.0 Generic abstractions related to dispatching event symfony/expression-language v6.0.3 v6.0.3 Provides an engine that can compile and evaluate expressions symfony/filesystem v6.0.3 v6.0.3 Provides basic utilities for the filesystem symfony/finder v6.0.3 v6.0.3 Finds files and directories via an intuitive fluent interface symfony/flex v2.1.4 v2.1.6 Composer plugin for Symfony symfony/form v6.0.3 v6.0.3 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v6.0.4 v6.0.4 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/http-client v6.0.3 v6.0.3 Provides powerful methods to fetch HTTP resources synchronously or asynchronously symfony/http-client-contracts v3.0.0 v3.0.0 Generic abstractions related to HTTP clients symfony/http-foundation v6.0.3 v6.0.3 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v6.0.4 v6.0.4 Provides a structured process for converting a Request into a Response symfony/intl v6.0.3 v6.0.3 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library symfony/mailer v6.0.3 v6.0.3 Helps sending emails symfony/maker-bundle v1.36.4 v1.37.0 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about writing boilerplate code. symfony/messenger v6.0.3 v6.0.3 Helps applications send and receive messages to/from other applications or via message queues symfony/mime v6.0.3 v6.0.3 Allows manipulating MIME messages symfony/monolog-bridge v6.0.3 v6.0.3 Provides integration for Monolog with various Symfony components symfony/monolog-bundle v3.7.1 v3.7.1 Symfony MonologBundle symfony/notifier v6.0.3 v6.0.3 Sends notifications via one or more channels (email, SMS, ...) symfony/options-resolver v6.0.3 v6.0.3 Provides an improved replacement for the array_replace PHP function symfony/password-hasher v6.0.3 v6.0.3 Provides password hashing utilities symfony/polyfill-intl-grapheme v1.24.0 v1.24.0 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.24.0 v1.24.0 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.24.0 v1.24.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.24.0 v1.24.0 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.24.0 v1.24.0 Symfony polyfill for the Mbstring extension symfony/polyfill-php81 v1.24.0 v1.24.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions symfony/process v6.0.3 v6.0.3 Executes commands in sub-processes symfony/property-access v6.0.3 v6.0.3 Provides functions to read and write from/to an object or array using a simple string notation symfony/property-info v6.0.3 v6.0.3 Extracts information about PHP class' properties using metadata of popular sources symfony/proxy-manager-bridge v6.0.3 v6.0.3 Provides integration for ProxyManager with various Symfony components symfony/routing v6.0.3 v6.0.3 Maps an HTTP request to a set of configuration variables symfony/runtime v6.0.3 v6.0.3 Enables decoupling PHP applications from global state symfony/security-acl v3.3.0 v3.3.1 Symfony Security Component - ACL (Access Control List) symfony/security-bundle v6.0.3 v6.0.3 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/security-core v6.0.3 v6.0.3 Symfony Security Component - Core Library symfony/security-csrf v6.0.3 v6.0.3 Symfony Security Component - CSRF Library symfony/security-http v6.0.3 v6.0.3 Symfony Security Component - HTTP Integration symfony/serializer v6.0.3 v6.0.3 Handles serializing and deserializing data structures, including object graphs, into array structures or other formats like XML and JSON. symfony/service-contracts v3.0.0 v3.0.0 Generic abstractions related to writing services symfony/stopwatch v6.0.3 v6.0.3 Provides a way to profile code symfony/string v6.0.3 v6.0.3 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way symfony/translation v6.0.3 v6.0.3 Provides tools to internationalize your application symfony/translation-contracts v3.0.0 v3.0.0 Generic abstractions related to translation symfony/twig-bridge v6.0.3 v6.0.3 Provides integration for Twig with various Symfony components symfony/twig-bundle v6.0.3 v6.0.3 Provides a tight integration of Twig into the Symfony full-stack framework symfony/validator v6.0.3 v6.0.3 Provides tools to validate values symfony/var-dumper v6.0.3 v6.0.3 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v6.0.3 v6.0.3 Allows exporting any serializable PHP data structure to plain PHP code symfony/web-link v6.0.3 v6.0.3 Manages links between resources symfony/web-profiler-bundle v6.0.3 v6.0.3 Provides a development tool that gives detailed information about the execution of any request symfony/webapp-meta v1.0.0 v1.0.0 A meta package for the web app pack symfony/webpack-encore-bundle v1.13.2 v1.14.0 Integration with your Symfony app & Webpack Encore! symfony/yaml v6.0.3 v6.0.3 Loads and dumps YAML files ```

PHP version

PHP 8.1.2 (cli) (built: Jan 26 2022 16:40:42) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.2, Copyright (c) Zend Technologies

ModelType doesn't work properly

I have category and subcategories, but when I try to save Category with sub categories, the sub categories doesn't save :/

But when I test with ModelAutoCompleteType it works :O

[eerison]

I tested with those options

it works ✅ ->add('subCategories', ModelAutocompleteType::class, ['multiple' => true, 'property' => 'name'])

it does not work ❌ ->add('subCategories', ModelType::class, ['multiple' => true]) ->add('subCategories')

Category Entity

show

```php subCategories = new ArrayCollection(); } public function __toString(): string { return $this->getName(); } public function getId(): ?int { return $this->id; } public function getName(): ?string { return $this->name; } public function setName(string $name): self { $this->name = $name; return $this; } public function getCategory(): ?self { return $this->category; } public function setCategory(?self $category): self { $this->category = $category; return $this; } /** * @return Collection|self[] */ public function getSubCategories(): Collection { return $this->subCategories; } public function addSubCategory(self $subCategory): self { if (!$this->subCategories->contains($subCategory)) { $this->subCategories[] = $subCategory; $subCategory->setCategory($this); } return $this; } public function removeSubCategory(self $subCategory): self { if ($this->subCategories->removeElement($subCategory)) { // set the owning side to null (unless already changed) if ($subCategory->getCategory() === $this) { $subCategory->setCategory(null); } } return $this; } } ```

[VincentLanglet]

I never use those field, but it's kinda surprising. We didn't modify the code often and no issue was created before. Dunno if an older version solve the issue.

Did you tried to debug the vendors ? Do you have an exception or it just does nothing ?

[eerison]

I never use those field, but it's kinda surprising. We didn't modify the code often and no issue was created before. Dunno if an older version solve the issue.

Did you tried to debug the vendors ? Do you have an exception or it just does nothing ?

It doesn't throw any exception :/

I'll try to debug :)

[eerison]

I found the problem!

when I use just

->add('subCategories')

it was using EntityType from Symfony

Then I tried again with ModelType, after struggle a bit, I tried with by_reference => false, then it works!

->add('subCategories', ModelType::class, ['multiple' => true, 'by_reference' => false])

@VincentLanglet is there any constant to use with those conf ?

example

->add(
    'subCategories',
    ModelType::class,
    [
        ModelType::Multiple => true,
        ModelType::ByReference' => false,
    ]
)

Edit 1: it works with EntityType too, I just needed to add the option by_reference => false

[VincentLanglet]

I'm not fully aware of the purpose of 'by_reference' => false but I know we are always using this on our OneToMany form, for sonata or symfony forms.

Dunno if there is a bug, or it's just a lack of documentation/understanding of the option and it's considered "obvious" that you have to use this option in your case...

@VincentLanglet is there any constant to use with those conf ?

No, I would say

->add('subCategories', ModelType::class, ['multiple' => true, 'by_reference' => false])

is fine. Like you would do for a class formType.

[eerison]

I was thinking to check the type of getProperty()

If it's some doctrine collection I would put "by_refence" => false as default

Or do you think, it's better investigate what exactly this by_reference do and check if it's a bug or not?

[VincentLanglet]

Adding by reference false is risky because maybe it need to be true for some others people in some others condition.

Also, changing the default behavior is a Bc break.

So yes, I would prefer to understand more the option, and maybe adding some doc to sonata could be considered as enough

For instance when I use a CollectionType from symfony I add by reference false by myself, symfony doesnt add it by default for me.

[eerison]

For instance when I use a CollectionType from symfony I add by reference false by myself, symfony doesnt add it by default for me.

Hmm, I don't really get what you mean (symfony doesnt add it by default for me.) Add what by default?

So yes, I would prefer to understand more the option, and maybe adding some doc to sonata could be considered as enough

Yeah meek sense for me, well I guess we can close this issue

[VincentLanglet]

https://symfony.com/doc/current/reference/forms/types/collection.html#by-reference

The default value is true. And everytime I used a CollectionType I need to add by reference false.