search

sonata-project / SonataMediaBundle

Symfony SonataMediaBundle
https://docs.sonata-project.org/projects/SonataMediaBundle
MIT License
449 stars 496 forks source link

Remove id from model classes #1577

Closed core23 closed 3 years ago

core23 commented 5 years ago

Feature Request

The id should not be part of the model classes. The outside world shouldn't know anything about the technical details. Depending on the user application, the id could be a string, uuid or an integer.

Classes:

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

jordisala1991 commented 3 years ago

Even though it would be nice to remove it, it is not an easy-pick. getId() is used in a lot of places for all models.

IMO it shouldn't matter if we define the getter, but it would be nice to be able to use whatever we want. That however requires tackle the uuid thing (already with an issue on the admin bundle https://github.com/sonata-project/SonataAdminBundle/issues/7327 .

Im closing it for now. If you think with my arguments this is still relevant, please reopen.