search

sonata-project / SonataMediaBundle

Symfony SonataMediaBundle
https://docs.sonata-project.org/projects/SonataMediaBundle
MIT License
449 stars 496 forks source link

AdminBundle mandatory in 4-x branch ? #2143

Closed nicolas-anaxago closed 2 years ago

nicolas-anaxago commented 2 years ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/doctrine-extensions 1.13.1 1.13.1 Doctrine2 behavioral extensions sonata-project/exporter 2.7.0 2.8.0 Lightweight Exporter library sonata-project/form-extensions 1.9.0 1.11.0 Symfony form extensions sonata-project/intl-bundle 2.10.2 2.10.2 Symfony SonataIntlBundle sonata-project/media-bundle 4.x-dev 4c74f32 4.x-dev 4c74f32 Symfony SonataMediaBundle sonata-project/twig-extensions 1.7.0 1.9.0 Sonata twig extensions ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/asset v4.4.27 v5.3.4 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript fil... symfony/browser-kit v5.3.4 v5.3.4 Simulates the behavior of a web browser, allowing you to make requests, click on links and ... symfony/cache v4.4.27 v5.3.8 Provides an extended PSR-6, PSR-16 (and tags) implementation symfony/cache-contracts v2.4.0 v2.4.0 Generic abstractions related to caching symfony/config v4.4.27 v5.3.4 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v4.4.29 v5.3.7 Eases the creation of beautiful and testable command line interfaces symfony/css-selector v4.4.27 v5.3.4 Converts CSS selectors to XPath expressions symfony/debug v4.4.27 v4.4.31 Provides tools to ease debugging PHP code symfony/debug-bundle v5.1.11 v5.3.4 Provides a tight integration of the Symfony Debug component into the Symfony full-stack fra... symfony/dependency-injection v4.4.27 v5.3.8 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v2.4.0 v2.4.0 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v4.4.27 v5.3.8 Provides integration for Doctrine with various Symfony components symfony/dom-crawler v5.3.4 v5.3.7 Eases DOM navigation for HTML and XML documents symfony/dotenv v4.4.29 v5.3.8 Registers environment variables from a .env file symfony/error-handler v4.4.27 v5.3.7 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v4.4.27 v5.3.7 Provides tools that allow your application components to communicate with each other by dis... symfony/event-dispatcher-contracts v1.1.9 v2.4.0 Generic abstractions related to dispatching event symfony/expression-language v4.4.27 v5.3.7 Provides an engine that can compile and evaluate expressions symfony/filesystem v5.3.4 v5.3.4 Provides basic utilities for the filesystem symfony/finder v4.4.27 v5.3.7 Finds files and directories via an intuitive fluent interface symfony/flex v1.14.0 v1.16.3 Composer plugin for Symfony symfony/form v4.4.27 v5.3.8 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v4.4.27 v5.3.8 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/http-client v4.4.27 v5.3.8 Provides powerful methods to fetch HTTP resources synchronously or asynchronously symfony/http-client-contracts v2.4.0 v2.4.0 Generic abstractions related to HTTP clients symfony/http-foundation v5.3.6 v5.3.7 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v4.4.29 v5.3.9 Provides a structured process for converting a Request into a Response symfony/intl v4.4.27 v5.3.8 Provides a PHP replacement layer for the C intl extension that includes additional data fro... symfony/messenger v4.4.27 v5.3.9 Helps applications send and receive messages to/from other applications or via message queues symfony/mime v5.3.4 v5.3.8 Allows manipulating MIME messages symfony/monolog-bridge v4.4.27 v5.3.7 Provides integration for Monolog with various Symfony components symfony/monolog-bundle v3.4.0 v3.7.0 Symfony MonologBundle symfony/notifier v5.0.8 v5.3.9 A library to notify messages symfony/options-resolver v4.4.27 v5.3.7 Provides an improved replacement for the array_replace PHP function symfony/orm-pack v1.0.8 v2.1.0 A pack for the Doctrine ORM symfony/phpunit-bridge v5.3.4 v5.3.8 Provides utilities for PHPUnit, especially user deprecation notices management symfony/polyfill-ctype v1.23.0 v1.23.0 Symfony polyfill for ctype functions symfony/polyfill-iconv v1.12.0 v1.23.0 Symfony polyfill for the Iconv extension symfony/polyfill-intl-grapheme v1.23.1 v1.23.1 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.23.0 v1.23.0 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.23.0 v1.23.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.23.0 v1.23.0 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.23.1 v1.23.1 Symfony polyfill for the Mbstring extension symfony/polyfill-php56 v1.20.0 v1.20.0 Symfony polyfill backporting some PHP 5.6+ features to lower PHP versions symfony/polyfill-php72 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions symfony/polyfill-php73 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.23.1 v1.23.1 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/polyfill-php81 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions symfony/process v4.4.27 v5.3.7 Executes commands in sub-processes symfony/property-access v5.3.4 v5.3.8 Provides functions to read and write from/to an object or array using a simple string notation symfony/property-info v5.3.4 v5.3.8 Extracts information about PHP class' properties using metadata of popular sources symfony/routing v4.4.27 v5.3.7 Maps an HTTP request to a set of configuration variables symfony/security-bundle v4.4.27 v5.3.8 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/security-core v4.4.29 v5.3.8 Symfony Security Component - Core Library symfony/security-csrf v5.3.4 v5.3.4 Symfony Security Component - CSRF Library symfony/security-guard v4.4.27 v5.3.7 Symfony Security Component - Guard symfony/security-http v4.4.27 v5.3.8 Symfony Security Component - HTTP Integration symfony/serializer v4.4.27 v5.3.8 Handles serializing and deserializing data structures, including object graphs, into array ... symfony/service-contracts v2.4.0 v2.4.0 Generic abstractions related to writing services symfony/stopwatch v5.3.4 v5.3.4 Provides a way to profile code symfony/string v5.3.3 v5.3.7 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grap... symfony/swiftmailer-bundle v3.5.2 v3.5.2 Symfony SwiftmailerBundle symfony/templating v4.4.27 v5.3.7 Provides all the tools needed to build any kind of template system symfony/translation v4.4.27 v5.3.9 Provides tools to internationalize your application symfony/translation-contracts v2.4.0 v2.4.0 Generic abstractions related to translation symfony/twig-bridge v4.4.27 v5.3.7 Provides integration for Twig with various Symfony components symfony/twig-bundle v4.4.27 v5.3.4 Provides a tight integration of Twig into the Symfony full-stack framework symfony/validator v4.4.29 v5.3.8 Provides tools to validate values symfony/var-dumper v5.3.6 v5.3.8 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v5.3.4 v5.3.8 Allows exporting any serializable PHP data structure to plain PHP code symfony/web-link v4.4.27 v5.3.4 Manages links between resources symfony/web-profiler-bundle v5.0.11 v5.3.8 Symfony WebProfilerBundle symfony/webpack-encore-bundle v1.12.0 v1.12.0 Integration with your Symfony app & Webpack Encore! symfony/yaml v4.4.29 v5.3.6 Loads and dumps YAML files ```

PHP version

$ php -v
PHP 7.4.23 (cli) (built: Aug 26 2021 15:51:55) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.23, Copyright (c), by Zend Technologies

Subject

SonataAdminBundle mandatory in 4-x branch

Steps to reproduce

install MediaBundle without AdminBundle

Actual results

Class "Sonata\AdminBundle\Controller\CRUDController" not found while loading "Sonata\MediaBundle\Controller\MediaAdminController".

It seems sonata.media.controller.media.admin and sonata.media.controller.gallery.admin are loaded even if SonataAdminBundle is not installed

https://github.com/sonata-project/SonataMediaBundle/blob/4c74f328006f49cf452879f0ac9cc57d45cf5f09/src/Resources/config/controllers.php#L24-L32

https://github.com/sonata-project/SonataMediaBundle/blob/4c74f328006f49cf452879f0ac9cc57d45cf5f09/src/DependencyInjection/SonataMediaExtension.php#L44-L55

jordisala1991 commented 2 years ago

It should not be mandatory. Can you test #2150 ?

Also, mind to explain how are you using SonataMediaBundle? Do you have your own CMS system?