search

sonata-project / SonataPageBundle

This bundle provides a Site and Page management through container and block services
https://docs.sonata-project.org/projects/SonataPageBundle
MIT License
216 stars 209 forks source link

Remove coupling to NotificationBundle #1238

Closed core23 closed 2 years ago

core23 commented 3 years ago

Feature Request

This is the last bundle that relies on the SonataNotificationBundle for no good reason. The original idea was to allow async snapshot creation / cleanup. This can also be done via commands and shouldn't take too long for a normal number of pages.

To allow deprecating the usage, we could introduce a new SnapshotManagerInterface with two methods createSnapshotsForSite and cleanupSnashotsForSite.

WDYT @sonata-project/contributors

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

VincentLanglet commented 2 years ago

I'll close this in favor of https://github.com/sonata-project/SonataPageBundle/issues/1415