search

sonata-project / SonataPageBundle

This bundle provides a Site and Page management through container and block services
https://docs.sonata-project.org/projects/SonataPageBundle
MIT License
216 stars 209 forks source link

Removing a page doesn't work from the edit route (works using batch delete) #1708

Closed gremo closed 10 months ago

gremo commented 1 year ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle 4.25.0 4.25.0 The missing Symfony Admin Generator sonata-project/block-bundle 5.0.1 5.0.1 Symfony SonataBlockBundle sonata-project/classification-bundle 4.7.0 4.7.1 Symfony SonataClassificationBundle sonata-project/doctrine-extensions 2.3.0 2.3.0 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 4.13.0 4.13.0 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 3.1.1 3.2.0 Lightweight Exporter library sonata-project/form-extensions 2.0.0 2.0.0 Symfony form extensions sonata-project/media-bundle 4.10.1 4.10.1 Symfony SonataMediaBundle sonata-project/page-bundle 4.5.0 4.5.0 This bundle provides a Site and Page management through container and block services sonata-project/seo-bundle 3.7.0 3.7.0 Symfony SonataSeoBundle sonata-project/twig-extensions 2.1.0 2.1.0 Sonata twig extensions sonata-project/user-bundle 5.9.0 5.10.0 Symfony SonataUserBundle ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/asset v6.2.7 v6.3.0 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files symfony/browser-kit v6.2.7 v6.3.0 Simulates the behavior of a web browser, allowing you to make requests, click on links and submit forms programmatically symfony/cache v6.2.12 v6.3.1 Provides extended PSR-6, PSR-16 (and tags) implementations symfony/cache-contracts v3.3.0 v3.3.0 Generic abstractions related to caching symfony/config v6.2.7 v6.3.0 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v6.2.12 v6.3.0 Eases the creation of beautiful and testable command line interfaces symfony/css-selector v6.2.7 v6.3.0 Converts CSS selectors to XPath expressions symfony/debug-bundle v6.2.7 v6.3.0 Provides a tight integration of the Symfony VarDumper component and the ServerLogCommand from MonologBridge into the Symfony full-... symfony/dependency-injection v6.2.12 v6.3.1 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v3.3.0 v3.3.0 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v6.2.12 v6.3.1 Provides integration for Doctrine with various Symfony components symfony/doctrine-messenger v6.2.12 v6.3.1 Symfony Doctrine Messenger Bridge symfony/dom-crawler v6.2.12 v6.3.1 Eases DOM navigation for HTML and XML documents symfony/dotenv v6.2.8 v6.3.0 Registers environment variables from a .env file symfony/error-handler v6.2.11 v6.3.0 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v6.2.8 v6.3.0 Provides tools that allow your application components to communicate with each other by dispatching events and listening to them symfony/event-dispatcher-contracts v3.3.0 v3.3.0 Generic abstractions related to dispatching event symfony/expression-language v6.2.7 v6.3.0 Provides an engine that can compile and evaluate expressions symfony/filesystem v6.2.12 v6.3.1 Provides basic utilities for the filesystem symfony/finder v6.2.7 v6.3.0 Finds files and directories via an intuitive fluent interface symfony/flex v2.3.1 v2.3.1 Composer plugin for Symfony symfony/form v6.2.11 v6.3.0 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v6.2.12 v6.3.1 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/http-client v6.2.12 v6.3.1 Provides powerful methods to fetch HTTP resources synchronously or asynchronously symfony/http-client-contracts v3.3.0 v3.3.0 Generic abstractions related to HTTP clients symfony/http-foundation v6.2.12 v6.3.1 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v6.2.12 v6.3.1 Provides a structured process for converting a Request into a Response symfony/intl v6.2.12 v6.3.1 Provides access to the localization data of the ICU library symfony/mailer v6.2.12 v6.3.0 Helps sending emails symfony/maker-bundle v1.50.0 v1.50.0 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about writing boilerpla... symfony/messenger v6.2.12 v6.3.1 Helps applications send and receive messages to/from other applications or via message queues symfony/mime v6.2.10 v6.3.0 Allows manipulating MIME messages symfony/monolog-bridge v6.2.8 v6.3.1 Provides integration for Monolog with various Symfony components symfony/monolog-bundle v3.8.0 v3.8.0 Symfony MonologBundle symfony/notifier v6.2.8 v6.3.0 Sends notifications via one or more channels (email, SMS, ...) symfony/options-resolver v6.2.7 v6.3.0 Provides an improved replacement for the array_replace PHP function symfony/password-hasher v6.2.7 v6.3.0 Provides password hashing utilities symfony/phpunit-bridge v6.3.1 v6.3.1 Provides utilities for PHPUnit, especially user deprecation notices management symfony/polyfill-intl-grapheme v1.27.0 v1.27.0 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.27.0 v1.27.0 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.27.0 v1.27.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.27.0 v1.27.0 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.27.0 v1.27.0 Symfony polyfill for the Mbstring extension symfony/process v6.2.11 v6.3.0 Executes commands in sub-processes symfony/property-access v6.2.11 v6.3.0 Provides functions to read and write from/to an object or array using a simple string notation symfony/property-info v6.2.11 v6.3.0 Extracts information about PHP class' properties using metadata of popular sources symfony/routing v6.2.12 v6.3.1 Maps an HTTP request to a set of configuration variables symfony/runtime v6.2.12 v6.3.1 Enables decoupling PHP applications from global state symfony/security-acl v3.3.2 v3.3.2 Symfony Security Component - ACL (Access Control List) symfony/security-bundle v6.2.12 v6.3.1 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/security-core v6.2.8 v6.3.0 Symfony Security Component - Core Library symfony/security-csrf v6.2.7 v6.3.0 Symfony Security Component - CSRF Library symfony/security-http v6.2.11 v6.3.1 Symfony Security Component - HTTP Integration symfony/serializer v6.2.12 v6.3.1 Handles serializing and deserializing data structures, including object graphs, into array structures or other formats like XML an... symfony/service-contracts v3.3.0 v3.3.0 Generic abstractions related to writing services symfony/stopwatch v6.2.7 v6.3.0 Provides a way to profile code symfony/string v6.2.8 v6.3.0 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way symfony/translation v6.2.11 v6.3.0 Provides tools to internationalize your application symfony/translation-contracts v3.3.0 v3.3.0 Generic abstractions related to translation symfony/twig-bridge v6.2.8 v6.3.0 Provides integration for Twig with various Symfony components symfony/twig-bundle v6.2.7 v6.3.0 Provides a tight integration of Twig into the Symfony full-stack framework symfony/validator v6.2.12 v6.3.1 Provides tools to validate values symfony/var-dumper v6.2.12 v6.3.1 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v6.2.10 v6.3.0 Allows exporting any serializable PHP data structure to plain PHP code symfony/web-link v6.2.7 v6.3.0 Manages links between resources symfony/web-profiler-bundle v6.2.12 v6.3.1 Provides a development tool that gives detailed information about the execution of any request symfony/yaml v6.2.10 v6.3.0 Loads and dumps YAML files ```

PHP version

$ php -v
PHP 8.2.8 (cli) (built: Jul 10 2023 22:00:15) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.8, Copyright (c) Zend Technologies
    with Zend OPcache v8.2.8, Copyright (c), by Zend Technologies
    with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethans

Subject

Removing a page doesn't work from the edit route, it works only using batch delete:

sonata-page

Minimal repository with the bug

https://github.com/gremo/sonata-page-delete-bug

Steps to reproduce

See the minimal repository with the bug.

Expected results

The page can be deleted from the edit route.

Actual results

The page cannot be deleted.

c-Rolland commented 1 year ago

Hello

On postRemove() we call a method who create a page.

https://github.com/sonata-project/SonataPageBundle/blob/4.x/src/Admin/Extension/CreateSnapshotAdminExtension.php#L43

This is normal ? i have a similar issue on my project

cc @core23 @VincentLanglet

VincentLanglet commented 1 year ago

Was introduced here https://github.com/sonata-project/SonataPageBundle/pull/1293 and updated here https://github.com/sonata-project/SonataPageBundle/pull/1456

You can check if it works better for you without this code, and if so, look for what the previous devs was trying to fix and how to fix it differently.

c-Rolland commented 1 year ago

To fix the bug i think we can do this :

https://github.com/sonata-project/SonataPageBundle/blob/4.x/src/Admin/Extension/CreateSnapshotAdminExtension.php#L43

public function postRemove(AdminInterface $admin, object $object): void
{
    if ($object instanceof PageInterface) {
        return;   
    }

   $this->createByPage($object);
}

case 1 : $object instanceof PageInterface, we do nothing case 2 : $object instanceof BlockInterface, we create the page snapshot.

cc @VincentLanglet

VincentLanglet commented 1 year ago

Can you try opening a PR with this change then ? You'll see if the test introduced in https://github.com/sonata-project/SonataPageBundle/pull/1293 will still pass

And we will need an aditionnal test for your use case

GeraudBourdin commented 10 months ago

the patch is solving my issue on my side. it would be great if it was accepted :) kudo @c-Rolland for this patch ! while waiting for the patch to be accepted we have overrided the service sonata.page.admin.extension.snapshot to integrate the patch.

GeraudBourdin commented 10 months ago

Can you try opening a PR with this change then ? You'll see if the test introduced in #1293 will still pass

And we will need an aditionnal test for your use case

Please let me know how to better MR if needed. I would be very pleased to make this merge request accepted and contribute in the future. thanks

https://github.com/sonata-project/SonataPageBundle/pull/1721