sonata-project / SonataSeoBundle

Symfony SonataSeoBundle
https://docs.sonata-project.org/projects/SonataSeoBundle
MIT License
136 stars 90 forks source link

Change menu label to Breadcrumb menu #696

Closed eerison closed 2 years ago

eerison commented 2 years ago

Adding a name more specific for breadcrumb menu

I am targeting this branch, because This issue is into this branch.

Changelog

### Changed
- Changed `menu label` to `Breadcrumb menu`

It will sove the issue when we depends the block bundle and seo bundle, like in page bundle

Screenshot 2022-10-06 at 10 35 11
eerison commented 2 years ago

@VincentLanglet Can I let the others translation missing it? how do you usually handle new translations for all languages?

VincentLanglet commented 2 years ago

@VincentLanglet Can I let the others translation missing it? how do you usually handle new translations for all languages?

I generally try to add translation thanks to some knowledge, review or translator.

In french, breadcrumb menu is Menu fil d'Ariane

eerison commented 2 years ago

@VincentLanglet Can I let the others translation missing it? how do you usually handle new translations for all languages?

I generally try to add translation thanks to some knowledge, review or translator.

In french, breadcrumb menu is Menu fil d'Ariane

Ok I asked some guys and They suggested to translate Menu only, because Breadcrumb doesn't make sense!

eerison commented 2 years ago

Just to have a different icon, what do you think about this one

https://fontawesome.com/v5/icons/angle-double-right?s=solid&f=classic

or should I keep the same (bars)?

VincentLanglet commented 2 years ago

Just to have a different icon, what do you think about this one

https://fontawesome.com/v5/icons/angle-double-right?s=solid&f=classic

or should I keep the same (bars)?

This icon might be a good idea indeed

eerison commented 2 years ago
Screenshot 2022-10-06 at 11 17 30

Ok then it stays like this, I liked it 💅🏼

VincentLanglet commented 2 years ago

We're changing from fa to fas are we sure font awesome 5 is used by all the seoBundle users ? Or should we stay with something like <i class="fa fa-angle-double-right"></i> ?

eerison commented 2 years ago

We're changing from fa to fas are we sure font awesome 5 is used by all the seoBundle users ? Or should we stay with something like <i class="fa fa-angle-double-right"></i> ?

hmmm well I was following the sonata admin 4!

eerison commented 2 years ago

We're changing from fa to fas are we sure font awesome 5 is used by all the seoBundle users ? Or should we stay with something like <i class="fa fa-angle-double-right"></i> ?

hmmm well I was following the sonata admin 4!

I tested and it works on both way fa or fas

eerison commented 2 years ago

But as we require block bundle 4, I guess the user is more or less forced to use sonata 4, don't you?

VincentLanglet commented 2 years ago

But as we require block bundle 4, I guess the user is more or less forced to use sonata 4, don't you?

We dont force to use sonataAdmin 4. People might use just BlockBundle and SeoBubdle maybe...

I dunno where come from this icon, so I dunno if we can use font awesome 5 without a BC break...

eerison commented 2 years ago

well Ok lets use fa

eerison commented 2 years ago

@jordisala1991 could you review please 👀

jordisala1991 commented 2 years ago

Thank you @eerison