Compatibility with doctrine/common 3.0

jordisala1991 commented 3 years ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle 3.89.1 3.89.1 The missing Symfony Admin Generator sonata-project/block-bundle 3.22.0 4.5.0 Symfony SonataBlockBundle sonata-project/cache 2.1.1 2.1.1 Cache library sonata-project/datagrid-bundle 3.3.0 3.3.0 Symfony SonataDatagridBundle sonata-project/doctrine-extensions 1.11.0 1.11.0 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 3.29.0 3.29.0 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.5.1 2.5.1 Lightweight Exporter library sonata-project/form-extensions 1.9.0 1.9.0 Symfony form extensions sonata-project/media-bundle 3.30.0 3.30.0 Symfony SonataMediaBundle sonata-project/twig-extensions 1.5.1 1.5.1 Sonata twig extensions sonata-project/user-bundle 4.11.0 4.11.0 Symfony SonataUserBundle ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/amqp-messenger symfony/asset symfony/cache symfony/cache-contracts symfony/config symfony/console symfony/debug symfony/debug-bundle symfony/dependency-injection symfony/deprecation-contracts symfony/doctrine-bridge symfony/doctrine-messenger symfony/dotenv symfony/error-handler symfony/event-dispatcher symfony/event-dispatcher-contracts symfony/expression-language symfony/filesystem symfony/finder symfony/flex symfony/form symfony/framework-bundle symfony/http-client-contracts symfony/http-foundation symfony/http-kernel symfony/intl symfony/mailer symfony/maker-bundle symfony/messenger symfony/mime symfony/monolog-bridge symfony/monolog-bundle symfony/options-resolver symfony/phpunit-bridge symfony/polyfill-intl-grapheme symfony/polyfill-intl-icu symfony/polyfill-intl-idn symfony/polyfill-intl-normalizer symfony/polyfill-mbstring symfony/polyfill-php80 symfony/process symfony/property-access symfony/property-info symfony/redis-messenger symfony/routing symfony/security-acl symfony/security-bundle symfony/security-core symfony/security-csrf symfony/security-guard symfony/security-http symfony/service-contracts symfony/stopwatch symfony/string symfony/templating symfony/translation symfony/translation-contracts symfony/twig-bridge symfony/twig-bundle symfony/validator symfony/var-dumper symfony/var-exporter symfony/web-profiler-bundle symfony/webpack-encore-bundle symfony/yaml ``` v5.2.3 v5.2.3 Symfony AMQP extension Messenger Bridge v4.4.19 v5.2.3 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files v5.2.3 v5.2.3 Provides an extended PSR-6, PSR-16 (and tags) implementation v2.2.0 v2.2.0 Generic abstractions related to caching v4.4.19 v5.2.3 Helps you find, load, combine, autofill and validate configuration values of any kind v4.4.19 v5.2.3 Eases the creation of beautiful and testable command line interfaces v4.4.19 v4.4.19 Provides tools to ease debugging PHP code v4.4.19 v5.2.3 Provides a tight integration of the Symfony Debug component into the Symfony full-stack framework v4.4.19 v5.2.3 Allows you to standardize and centralize the way objects are constructed in your application v2.2.0 v2.2.0 A generic function and convention to trigger deprecation notices v4.4.19 v5.2.3 Provides integration for Doctrine with various Symfony components v5.2.3 v5.2.3 Symfony Doctrine Messenger Bridge v5.2.3 v5.2.3 Registers environment variables from a .env file v4.4.19 v5.2.3 Provides tools to manage errors and ease debugging PHP code v4.4.19 v5.2.3 Provides tools that allow your application components to communicate with each other by dispatching events and listening to them v1.1.9 v2.2.0 Generic abstractions related to dispatching event v5.2.3 v5.2.3 Provides an engine that can compile and evaluate expressions v5.2.3 v5.2.3 Provides basic utilities for the filesystem v5.2.3 v5.2.3 Finds files and directories via an intuitive fluent interface v1.12.2 v1.12.2 Composer plugin for Symfony v4.4.19 v5.2.3 Allows to easily create, process and reuse HTML forms v4.4.19 v5.2.3 Provides a tight integration between Symfony components and the Symfony full-stack framework v2.3.1 v2.3.1 Generic abstractions related to HTTP clients v4.4.19 v5.2.3 Defines an object-oriented layer for the HTTP specification v4.4.19 v5.2.3 Provides a structured process for converting a Request into a Response v5.2.3 v5.2.3 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library v5.2.3 v5.2.3 Helps sending emails v1.29.1 v1.29.1 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about writing boilerplate code. v5.2.3 v5.2.3 Helps applications send and receive messages to/from other applications or via message queues v5.2.3 v5.2.3 Allows manipulating MIME messages v5.2.3 v5.2.3 Provides integration for Monolog with various Symfony components v3.6.0 v3.6.0 Symfony MonologBundle v5.2.3 v5.2.3 Provides an improved replacement for the array_replace PHP function v5.2.3 v5.2.3 Provides utilities for PHPUnit, especially user deprecation notices management v1.22.1 v1.22.1 Symfony polyfill for intl's grapheme_* functions v1.22.1 v1.22.1 Symfony polyfill for intl's ICU-related data and classes v1.22.1 v1.22.1 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions v1.22.1 v1.22.1 Symfony polyfill for intl's Normalizer class and related functions v1.22.1 v1.22.1 Symfony polyfill for the Mbstring extension v1.22.1 v1.22.1 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions v5.2.3 v5.2.3 Executes commands in sub-processes v5.2.3 v5.2.3 Provides functions to read and write from/to an object or array using a simple string notation v5.2.3 v5.2.3 Extracts information about PHP class' properties using metadata of popular sources v5.2.3 v5.2.3 Symfony Redis extension Messenger Bridge v4.4.19 v5.2.3 Maps an HTTP request to a set of configuration variables v3.1.1 v3.1.1 Symfony Security Component - ACL (Access Control List) v4.4.19 v5.2.3 Provides a tight integration of the Security component into the Symfony full-stack framework v4.4.19 v5.2.3 Symfony Security Component - Core Library v5.2.3 v5.2.3 Symfony Security Component - CSRF Library v4.4.19 v5.2.3 Symfony Security Component - Guard v4.4.19 v5.2.3 Symfony Security Component - HTTP Integration v2.2.0 v2.2.0 Generic abstractions related to writing services v5.2.3 v5.2.3 Provides a way to profile code v5.2.3 v5.2.3 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way v4.4.19 v5.2.3 Provides all the tools needed to build any kind of template system v4.4.19 v5.2.3 Provides tools to internationalize your application v2.3.0 v2.3.0 Generic abstractions related to translation v4.4.19 v5.2.3 Provides integration for Twig with various Symfony components v4.4.19 v5.2.3 Provides a tight integration of Twig into the Symfony full-stack framework v4.4.19 v5.2.3 Provides tools to validate values v5.2.3 v5.2.3 Provides mechanisms for walking through any arbitrary PHP variable v5.2.3 v5.2.3 Allows exporting any serializable PHP data structure to plain PHP code v4.4.19 v5.2.3 Provides a development tool that gives detailed information about the execution of any request v1.11.1 v1.11.1 Integration with your Symfony app & Webpack Encore! v5.2.3 v5.2.3 Loads and dumps YAML files

PHP version

$ php -v
PHP 7.4.15 (cli) (built: Feb  9 2021 19:48:41) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.15, Copyright (c), by Zend Technologies
    with Xdebug v3.0.2, Copyright (c) 2002-2021, by Derick Rethans

Subject

When upgrading to the latest release of this bundle, I've got an error with the registration of FosUserBundle commands. The cause is this PR: https://github.com/sonata-project/SonataUserBundle/pull/1325

That PR upgraded the doctrine/common and persistence packages to the next major version, giving some protection layer with FOSUser (that it is not compatible).

I have tried the cache:clear or removing completely the cache directory, but it does not work.

Steps to reproduce

Upgrade SontaUserBundle and doctrine/* packages related.
Try to execute some console commands

Expected results

Execute commands without warnings or errors.

Actual results

 [WARNING] Some commands could not be registered:

In UserManager.php line 41:

  Argument 3 passed to FOS\UserBundle\Doctrine\UserManager::__construct() mus
  t be an instance of Doctrine\Common\Persistence\ObjectManager, instance of
  Doctrine\ORM\EntityManager given, called in /usr/app/var/cache/dev/Containe
  rD8hTDUh/getSonata_User_UserManagerService.php on line 16

jordisala1991 commented 3 years ago

Maybe @phansys can help here.

jordisala1991 commented 3 years ago

I think the problem comes from the fact that SonataUserExtension only executes on empty cache, and you need to declare class aliases on each request, not only on fresh cache.

Maybe moving the code to the bundle class helps solving the issue

gansky-alexander commented 3 years ago

I had same issue for sonata-project/admin-bundle:3.89.1 I changed version to 3.88.0 and it solves the problem.

gansky-alexander commented 3 years ago

No, i was wrong, after composer all works fine but then issue returns back. How can i fix it in my code?

phansys commented 3 years ago

How can i fix it in my code?

Until a new version spreading these aliases is released, you can register them manually in your project:

if (!interface_exists(\Doctrine\Common\Persistence\ObjectManager::class)) {
    class_alias(\Doctrine\Persistence\ObjectManager::class, \Doctrine\Common\Persistence\ObjectManager::class);
}

if (!class_exists(\Doctrine\Common\Persistence\Event\LifecycleEventArgs::class)) {
    class_alias(\Doctrine\Persistence\Event\LifecycleEventArgs::class, \Doctrine\Common\Persistence\Event\LifecycleEventArgs::class);
}

sonata-project / SonataUserBundle