Using this bundle without SonataAdminBundle

[supersmile2009]

Hi. Would making the SonataAdminBundle an optional dependency for v5 be something you could consider? It wouldn't be a BC break, since v5 is still in pre-release. And I could volunteer to implement the necessary changes. In fact running it without the Admin bundle was possible with v4 with a bit of trickery in composer.json. But service configuration in v5 makes things a bit more complicated. The key changes required to make it work are:

1. Moving some config processing logic into this if block

   # Sonata\UserBundle\DependencyInjection\SonataUserExtension.php
       if (isset($bundles['SonataAdminBundle'])) {
           $loader->load('admin.php');
           $loader->load(sprintf('admin_%s.php', $config['manager_type']));
       }

2. And sonata.user.twig.global (Sonata\UserBundle\Twig\GlobalVariables) shouldn't have a hard dependency on Sonata\AdminBundle\Admin\Pool.

Would you be open to such PR?

[core23]

I'm not a big fan of optional dependencies. They can bring complex problems, e.g. if you want sonata admin functionality, but not for the user bundle. The user bundle could restrict you from installing the latest bundle.

That's why I forked this project and the FOSUserBundle. If you're interested in smaller, atomic feature bundles, you can try this:

• https://github.com/nucleos/NucleosUserBundle
• https://github.com/nucleos/NucleosProfileBundle
• https://github.com/nucleos/NucleosUserAdminBundle

[VincentLanglet]

I'm not a big fan of optional dependencies. They can bring complex problems, e.g. if you want sonata admin functionality, but not for the user bundle. The user bundle could restrict you from installing the latest bundle.

The SonataAdminBundle is already an optional dependency of

• SonataMediaBundle https://github.com/sonata-project/SonataMediaBundle/blob/4.x/composer.json
• SonataClassificationBundle https://github.com/sonata-project/SonataClassificationBundle/blob/4.x/composer.json

So I think it's not a bad idea to do the same for the SonataUserBundle and I would say PR are welcomed.

WDYT @jordisala1991 ?

[jordisala1991]

I was about to look at the same info. If that is the case for others, PRs welcome indeed.