search

sonata-project / dev-kit

Development kit of the Sonata-Project
https://master-7rqtwti-ptm4dx6rjpjko.eu-5.platformsh.site/
42 stars 42 forks source link

Use another kind of comment for dropping support of packages #1181

Closed franmomu closed 2 years ago

franmomu commented 3 years ago

Right now we use NEXT_MAJOR for everything. IMO we should use another kind of comment when it is related to dropping support for packages because this can be done in a minor version.

Related: https://github.com/sonata-project/SonataMediaBundle/pull/1814#discussion_r492047513 and https://github.com/sonata-project/SonataAdminBundle/pull/6465/files#r505919696

It would be nice to include the composer package name (symfony/config, friendsofsymfony/rest-bundle, etc) to be easy to find.

And about what kind of comment, I have no idea, I've been thinking... but I couldn't come up with something I like.

VincentLanglet commented 3 years ago

And about what kind of comment, I have no idea, I've been thinking... but I couldn't come up with something I like.

TODO ?

phansys commented 3 years ago

DEPENDENCIES? MAINTENANCE?

greg0ire commented 3 years ago

REQUIRES_BUMP $package $version $whatNeedsToBeDone?

core23 commented 3 years ago

I would prefer something that speaks to the user and is not so technical releated like the NEXT_MAJOR comment. But I have no idea what it could be :( Maybe TODO as it's more common

jordisala1991 commented 2 years ago

We are currently using TODO. Can this be closed?