sonata-project / dev-kit

Development kit of the Sonata-Project
https://master-7rqtwti-ptm4dx6rjpjko.eu-5.platformsh.site/
42 stars 42 forks source link

[RFC] Remove coupling to SonataAdminBundle #537

Closed core23 closed 3 years ago

core23 commented 4 years ago

This might be a controversial topic, but what do you think about removing the hard backend dependency to the SonataAdminBundle from our feature bundles and create new backend bundles (e.g. SonataNewsAdminBundle)? This would help to decouple our projects more and more.

The following projects are affected:

:+1: Pro

:-1: Contra

VincentLanglet commented 3 years ago

It would be interesting to know which % of sonata users are using those bundle without any interest in the AdminBundle. My personal opinion is "none or not a lot". This extra work, extra projects, extra maintenance, ... would be only useful for those users ; so I don't see a real interest.

This "remove coupling to SonataAdminBundle" was already started with the creation of the DatagridBundle.

This now have tons of issues:

In a perfect world, we would have

Controversial opinion: this is too much work/maintenance for the maintainers we have with too low benefit for the users we have.

Here, if I understand correctly for the SonataMediaBundle (and the other), we would have

It's a nice idea on the paper. But I wonder if this would be really useful for the community we have. It could be interesting to create a poll on twitter with the sonata-project account in order to know which % of users are not using the AdminBundle.

Also if we plan to keep splitting bundle, a mono-repository would be better.

core23 commented 3 years ago

Controversial opinion: this is too much work/maintenance for the maintainers we have with too low benefit for the users we have.

As we have a lack of active core members at the moment, we should not spend any more time on this issue.

Off topic: I wonder if sonata is still a fancy project that is used for new projects / developers or if EasyAdmin is more famous. Symfony stopped listing us on their project list and it feels like we core developers are the only people that open new pull requests and fix issues.

VincentLanglet commented 3 years ago

Off topic: I wonder if sonata is still a fancy project that is used for new projects / developers or if EasyAdmin is more famous. Symfony stopped listing us on their project list and it feels like we core developers are the only people that open new pull requests and fix issues.

The list from Symfony is pretty reduced, I assume they removed sonata because they want to promote EasyAdmin. I merged multiple bug fix coming from non-core-developer and if we look at the stats it seems used a lot. https://packagist.org/packages/sonata-project/admin-bundle/stats

The fact we didn't support Symfony 5 for a long time hurt sonata. New projects/developers had to use Symfony 4 in order to use SonataAdmin (that's why we got issue about sf5/twig3).

But the stable release of the v4 should come soon.