search

sonata-project / exporter

Lightweight Exporter library
https://docs.sonata-project.org/projects/exporter
MIT License
438 stars 88 forks source link

Sonata\Exporter\Handler uses deprecated interface SourceIteratorInterface #552

Closed jderusse closed 2 years ago

jderusse commented 2 years ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' Color legend: - patch or minor release available - update recommended - major release available - update possible - up to date version sonata-project/admin-bundle 4.2.1 4.2.2 The missing Symfony Admin Generator sonata-project/block-bundle 4.8.0 4.8.0 Symfony SonataBlockBundle sonata-project/cache 2.2.0 2.2.0 Cache library sonata-project/datagrid-bundle 3.4.2 3.4.2 Symfony SonataDatagridBundle sonata-project/doctrine-extensions 1.15.0 1.15.0 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 4.1.0 4.1.0 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.9.0 2.9.1 Lightweight Exporter library sonata-project/form-extensions 1.12.1 1.12.1 Symfony form extensions sonata-project/twig-extensions 1.9.0 1.9.0 Sonata twig extensions ```

Subject

In https://github.com/sonata-project/exporter/pull/532 the SourceIteratorInterface interface has been deprecated, but the class Sonata\Exporter\Handler still expect an instance of SourceIteratorInterface.

So we don't have any way to fix the deprecation.

VincentLanglet commented 2 years ago

Do you want to make the PR @jderusse ? SourceIteratorInterface is deprecated in favor of \Iterator, so changing the typehint to \Iterator would solve the issue.