search

songkick / oauth2-provider

Simple OAuth 2.0 provider toolkit
MIT License
528 stars 148 forks source link

Redirect URL #54

Closed waynerobinson closed 11 years ago

waynerobinson commented 11 years ago

Is the code at the following correct? https://github.com/songkick/oauth2-provider/blob/master/lib/songkick/oauth2/provider/authorization.rb#L100

It seems to be redirecting to:

"#{ base_redirect_uri }##{ fragment }"

however, shouldn't this be:

"#{ base_redirect_uri }#{ q }#{ fragment }"

and shouldn't the key be oauth_token instead of code or am I missing something?

jcoglan commented 11 years ago

No, draft-10 says that for response_type=token all response params must be returned in the URL fragment. What do you mean about the key?

waynerobinson commented 11 years ago

Never mind, I think I worked it all out. It was just my misunderstanding of some of the new V2.0 OAuth elements.