songz / cordova-plugin-opentok

Cordova Plugin for OpenTok - add webrtc video to your iOS or Android App
Other
162 stars 270 forks source link

On disconnect and reconnect a black screen in place of for publisher div which does not get cleared. #92

Closed ghost closed 10 years ago

ghost commented 10 years ago

I have publisher and subscriber divs positioned with relative. On publish I compute the height, width and sets the top and left positions so that the publisher is displayed at bottom right corner. After that I call TB.updateViews() to get it to reposition. It works well for the first time. If the session disconnects and then reconnect it or if I disconnect and later come back and opens a new session, the publisher video gets repositioned and everything works but there appears to be a black screen on the top left corner and it remains there until the app is restarted. The screen remain even if I remove the containers and there seems to be no new element or CSS added to the DOM that makes it black. Initially the publisher has top and left set to -9999px.

Testing on Galaxy S3 with Gellybean. OpenTok plugin v1.0.2 (opentok-android-sdk-2.0.jar)

Screenshot: On first time. Publisher at bottom right (works fine). screenshot_2014-09-18-10-55-35

Screenshot: Session ended, then reconnected, publisher updates position as usual, publishes video, but black screen on top left corner. (This pic displays when session is ended and app is taken to previous page). screenshot_2014-09-18-10-56-52

songz commented 10 years ago

Hey, I just tested this and could not reproduce. I remember this being a problem awhile back but its been fixed. If you upgrade your cordova version you should not see this problem anymore. Fix is either https://github.com/songz/cordova-plugin-opentok/pull/77 or https://github.com/songz/cordova-plugin-opentok/pull/79

Btw, thanks alot for your pull request!

ghost commented 10 years ago

Right, I updated the opentok plugin to the latest version and the bug is no longer present. This fixes the issue.

songz commented 10 years ago

yay!