Closed Wick324 closed 1 year ago
@renukamanavalan I think this is a serious bug, could you explain this?
@panyi5534 , I agree, the order of parameters in a query, should not matter. Could you raise a PR with suggested fix ?
@renukamanavalan I rised a pr to fix it, please check it. I will close this issue. https://github.com/sonic-net/sonic-gnmi/pull/50
When I use gnmi_get to get data, if the path contains 2 or more keys, the result of the same operation is different.
As I know, it is caused by the unordered map of proto serialization. For example, the path "/sonic-acl:sonic-acl/ACL_RULE/ACL_RULE_LIST[aclname=1][rulename=2]" convert to [sonic-acl:sonic-aclACL_RULE ACL_RULE_LIST map[aclname:1 rulename:2]],but the map is not ordered, so the result of proto serialization cannot be accurate.
Operation record:
server log:
I wonder if this situation is correct. If so, what is the reason for this design, and what needs to be paid attention to. If not, is there a solution plan?