sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
200 stars 730 forks source link

[Bug]: test_lldp_neighbor_post_orchagent_reboot fails for multi-asic #14689

Open anamehra opened 2 months ago

anamehra commented 2 months ago

Issue Description

https://github.com/sonic-net/sonic-mgmt/pull/14616 introduced new test test_lldp_neighbor_post_orchagent_reboot The test case does not handle multi-asic scenario and fails for multi-asic DUT

Results you see

On multi-asic platform, the tests try to disable swss0 feature. feature names should not be appended with namespace number.

      raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)

E tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results => E {"changed": true, "cmd": "sudo config feature autorestart swss0 disabled", "delta": "0:00:01.131598", "end": "2024-09-22 09:24:54.296006", "failed": true, "msg": "non-zero return code", "rc": 1, "start": "2024-09-22 09:24:53.164408", "stderr": "", "stderr_lines": [], "stdout": "Feature 'swss0' doesn't exist", "stdout_lines": ["Feature 'swss0' doesn't exist"]}

Results you expected to see

The test should pass on multi-asic as well

Is it platform specific

generic

Relevant log output

No response

Output of show version

No response

Attach files (if any)

No response

anamehra commented 2 months ago

Hi @abdosi , for you viz.

arlakshm commented 1 month ago

New test added, does not handle multi-asic.

arlakshm commented 1 month ago

Another PR #13172 in flight for fixing the lldp failures on multi-asic devices for existing test. @anamehra to fix this new test after #13172 is merged.

anamehra commented 2 days ago

looks like recent changes in lldp script handles this scenario.

anamehra commented 1 day ago

needs fix.