search

sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
200 stars 732 forks source link

[action] [PR:15524] Fixing the import error and KeyError in snappi_test/multidut executions. #15694

Closed mssonicbld closed 4 days ago

mssonicbld commented 1 week ago

@sdszhang : This PR attempts to fix the fixture-not-found error and KeyError that you are seeing in the snappi_test multidut runs. Pls let me know if this works for you.

mssonicbld commented 1 week ago

Original PR: https://github.com/sonic-net/sonic-mgmt/pull/15524

mssonicbld commented 1 week ago

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py:36:25: F811 redefinition of unused 'setup_ports_and_dut' from line 21

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
  2. Ensure that the pre-commit package is installed: 
    sudo pip install pre-commit
  3. Go to repository root folder
  4. Install the pre-commit hooks: 
    pre-commit install
  5. Use pre-commit to check staged file: 
    pre-commit
  6. Alternatively, you can check committed files using: 
    pre-commit run --from-ref <commit_id> --to-ref <commit_id>
sdszhang commented 1 week ago

@rraghav-cisco the cherry-picked failed with static analysis. can you manually cherry pick the PR into 202405?

tests/snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py:36:25: F811 redefinition of unused 'setup_ports_and_dut' from line 21
rraghav-cisco commented 6 days ago

This PR attempts to fix the fixture-not-found error and KeyError that you are seeing in the snappi_test multidut runs. Pls let me know if this works for you.

@sdszhang , 202405 PR: https://github.com/sonic-net/sonic-mgmt/pull/15713

sdszhang commented 4 days ago

close this one as it's being cherry picked manually.