sonic-net / sonic-sairedis

SAI object interface to Redis database, as used in the SONiC project
Other
56 stars 273 forks source link

[syncd] Add workaround for port error status notification #1430

Closed kcudnik closed 4 weeks ago

kcudnik commented 1 month ago

Adding new field in port status notification is breaking change and can cause some issues when getting notification from older SAI library, this will add workaround to handle that case

kcudnik commented 1 month ago

I'm just creating this PR to see what i miss from build, i will later split this to 2 PR's as advancing SAI submodule and then commiting actual workaround

prgeor commented 1 month ago

@kcudnik could you please check the build failure.

kcudnik commented 1 month ago

Yes, already fixed in latest pr #1431 but swss repo tests are failing because of sai backward compatibility break, I already fixed that and posted pr on swss repo pleased follow thread on #1431

kcudnik commented 1 month ago

SAI was updated in separate PR: https://github.com/sonic-net/sonic-sairedis/pull/1431

kcudnik commented 1 month ago

/azp run

azure-pipelines[bot] commented 1 month ago
Azure Pipelines successfully started running 1 pipeline(s).
kcudnik commented 1 month ago

@prgeor why there was force push to my branch from you?

prgeor commented 1 month ago

@prgeor why there was force push to my branch from you?

@kcudnik its not allowing otherwise to merge

image