sonic-net / sonic-sairedis

SAI object interface to Redis database, as used in the SONiC project
Other
56 stars 273 forks source link

Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option #1437

Closed stephenxs closed 2 weeks ago

stephenxs commented 1 month ago

Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option

  1. Read the counter groups that support bulk mode from CONFIG_DB.DEVICE_METADATA|localhost.supporting_bulk_counter_groups
  2. Generate CLI options to syncd
  3. Based on CLI options syncd records the counter groups that support bulk mode. For those objects, we do not need to poll them in bulk mode during initialization
kcudnik commented 1 month ago

/azp run

azure-pipelines[bot] commented 1 month ago
Azure Pipelines successfully started running 1 pipeline(s).
stephenxs commented 4 weeks ago

@kcudnik I added UT to meet coverage.

stephenxs commented 4 weeks ago

UT failed due to a conflict with another PR. Fixing.

stephenxs commented 2 weeks ago

Same infra issue as that in another PR

vslib/.libs'
+ for dir in ${gcov_dirs}
++ dirname common/.libs
+ source_dir=common
+ output_file=coverage-common.json
+ gcovr --exclude-unreachable-branches --json-pretty -o coverage-common.json --object-directory common common/.libs
+ for dir in ${gcov_dirs}
++ dirname common/c-api/.libs
+ source_dir=common/c-api
+ output_file=coverage-common/c-api.json
+ gcovr --exclude-unreachable-branches --json-pretty -o coverage-common/c-api.json --object-directory common/c-api common/c-api/.libs
usage: gcovr [options] [search_paths...]
gcovr: error: argument -o/--output: Could not create output file 'coverage-common/c-api.json': No such file or directory
bingwang-ms commented 2 days ago

@kcudnik Can you please confirm if this PR is required for 202405?

kcudnik commented 2 days ago

@bingwang-ms please ask @stephenxs to confirm

stephenxs commented 2 days ago

@bingwang-ms please ask @stephenxs to confirm

Yes, we need it in 202405. @bingwang-ms