search

sonic-pi-net / sonic-pi

Code. Music. Live.
https://sonic-pi.net
Other
10.84k stars 923 forks source link

Use Ruby 3.3 for Windows CI #3393

Open Artalus opened 7 months ago

Artalus commented 7 months ago

Ruby 3.2 has issues with non-English entries in Registry.

Relates to #3371 and probably other crash reports mentioning Error reading ports via Boot Daemon STDOUT.

UPD: Was going to simply check if the project even builds with 3.3, but GHA says This workflow is awaiting approval from a maintainer 😞

ethancrawford commented 7 months ago

Have kicked it off. Fingers crossed 😄

Artalus commented 7 months ago

Linux and Mac failed while building libsndfile, which is probably an unrelated error somewhere in vcpkg ports. I don't have much experience with it sadly, aside from it never working the way I wanted 😅

Windows built successfully but failed at ctest with 

Error: An error occurred trying to start process 'C:\Windows\system32\cmd.EXE' with working directory 'D:\a\sonic-pi\sonic-pi/app/build/api-tests'. The directory name is invalid

which is cryptic as well - both the last commit changing the workflow https://github.com/sonic-pi-net/sonic-pi/commit/aa63dc7621c90e85acc8ab5003692e627ac0bfd5 and the last commit built before mine https://github.com/sonic-pi-net/sonic-pi/commit/fa6e49fd329bf3677c5c8060b6e27546a46c9bc1 were built successfully... This might be just a random CI quirk requiring a simple re-run, but I kinda doubt it.

samaaron commented 7 months ago

I just updated vcpkg to the latest release and it still seems to be failing as described above. Not sure what's going on here at all.

I did manage to build things successfully with Qt 6.7 on my Apple Silicon Mac - so it's possible it might be an issue with vcpkg and the CI?

If anyone can help I'd love to hear your thoughts....

Oh, and updating Ruby to 3.3 in the CI only affects the tests. Release builds are currently manually built - and Sonic Pi is designed to support Ruby back to v2.x

samaaron commented 7 months ago

Possibly related: https://github.com/microsoft/vcpkg/issues/38112#issuecomment-2049214652

Artalus commented 7 months ago

If anyone can help I'd love to hear your thoughts....

I might take a look at it at some point in a fork, but I am knee-deep in other random stuff nowadays, so I cannot promise anything 😅

Oh, and updating Ruby to 3.3 in the CI only affects the tests. Release builds are currently manually built

Yup, figured that much since the only upload in the workflow is related to logs 🙃 . Wanted simply to check preemptively that the upgrade wouldn't break the build at the very least.

samaaron commented 7 months ago

For the record, today I built the latest Sonic Pi with Ruby 3.3 and Qt 6.7 on my Windows machine and it seems to be working just fine.