sonic2kk / steamtinkerlaunch

Linux wrapper tool for use with the Steam client for custom launch options and 3rd party programs
GNU General Public License v3.0
2.13k stars 71 forks source link

Unable to install MO2 or Vortex v11.1.20220920 #591

Closed srolfe closed 2 years ago

srolfe commented 2 years ago

I downloaded steam tinker launch master as a ZIP, extracted it and ran the commands in the wiki (./steamtinkerlaunch install && ./steamtinkerlaunch compat add). Restarted my device and configured steam tinker launch for Skyrim. In both game mode and desktop mode I cannot use MO2 or Vortex. When I try to click the MO2 button, my log shows as follows:

Tue Sep 20 11:33:27 AM EDT 2022 ERROR - getLatestMO2Ver - Could not find any 'Mod.Organizer' Release
Tue Sep 20 11:33:27 AM EDT 2022 SKIP - dlLatestMO2 - No MO2SETUP defined - nothing to download - skipping
Tue Sep 20 11:33:27 AM EDT 2022 SKIP - installMO2 - '' not found - nothing to install - skipping
Tue Sep 20 11:33:27 AM EDT 2022 INFO - prepareMO2 - Updating/creating ModOrganizer instances
Tue Sep 20 11:33:27 AM EDT 2022 SKIP - listSteamLibraries - not recreating already available '/dev/shm/steamtinkerlaunch/SteamLibraries.txt'
Tue Sep 20 11:33:27 AM EDT 2022 SKIP - setModGameSyms - '/run/media/DeckLinux/steamapps/compatdata/220200/pfx' missing - looks like the game was removed or never started yet
Tue Sep 20 11:33:27 AM EDT 2022 SKIP - setModGameSyms - '/run/media/DeckLinux/steamapps/compatdata/489830/pfx' missing - looks like the game was removed or never started yet
Tue Sep 20 11:33:27 AM EDT 2022 SKIP - setModGameSyms - '/run/media/DeckLinux/steamapps/compatdata/413150/pfx' missing - looks like the game was removed or never started yet
Tue Sep 20 11:33:27 AM EDT 2022 INFO - StatusWindow - for 'Installing 'ModOrganizer''
Tue Sep 20 11:33:27 AM EDT 2022 INFO - getLatestMO2Ver - Search for latest 'Mod.Organizer' Release under 'https://github.com/ModOrganizer2/modorganizer/releases'
Tue Sep 20 11:33:27 AM EDT 2022 ERROR - getLatestMO2Ver - Could not find any 'Mod.Organizer' Release
Tue Sep 20 11:33:27 AM EDT 2022 SKIP - dlLatestMO2 - No MO2SETUP defined - nothing to download - skipping
Tue Sep 20 11:33:27 AM EDT 2022 SKIP - installMO2 - '' not found - nothing to install - skipping
Tue Sep 20 11:33:28 AM EDT 2022 SKIP - manageMO2GInstance - argument 1 '' is invalid
Tue Sep 20 11:33:28 AM EDT 2022 INFO - StatusWindow - for 'Installing 'ModOrganizer''
Tue Sep 20 11:33:28 AM EDT 2022 INFO - getLatestMO2Ver - Search for latest 'Mod.Organizer' Release under 'https://github.com/ModOrganizer2/modorganizer/releases'
Tue Sep 20 11:33:28 AM EDT 2022 ERROR - getLatestMO2Ver - Could not find any 'Mod.Organizer' Release
Tue Sep 20 11:33:28 AM EDT 2022 SKIP - dlLatestMO2 - No MO2SETUP defined - nothing to download - skipping
Tue Sep 20 11:33:28 AM EDT 2022 SKIP - installMO2 - '' not found - nothing to install - skipping
Tue Sep 20 11:33:29 AM EDT 2022 SKIP - listSteamLibraries - not recreating already available '/dev/shm/steamtinkerlaunch/SteamLibraries.txt'
Tue Sep 20 11:33:29 AM EDT 2022 SKIP - setModGameSyms - '/run/media/DeckLinux/steamapps/compatdata/220200/pfx' missing - looks like the game was removed or never started yet
Tue Sep 20 11:33:29 AM EDT 2022 SKIP - setModGameSyms - '/run/media/DeckLinux/steamapps/compatdata/489830/pfx' missing - looks like the game was removed or never started yet
Tue Sep 20 11:33:29 AM EDT 2022 SKIP - setModGameSyms - '/run/media/DeckLinux/steamapps/compatdata/413150/pfx' missing - looks like the game was removed or never started yet
Tue Sep 20 11:33:29 AM EDT 2022 ERROR - prepareMO2 - No '/home/deck/.config/steamtinkerlaunch/mo2/compatdata/pfx/drive_c/Modding/MO2/ModOrganizer.exe' found - can't continue
Tue Sep 20 11:33:29 AM EDT 2022 SKIP - startMO2 - Could not find '/home/deck/.config/steamtinkerlaunch/mo2/compatdata/pfx/drive_c/Modding/MO2/ModOrganizer.exe' - can't start ModOrganizer - this should not happen

I tried using the command line (steamtinkerlaunch mo2 install) as well but did not notice a difference. When trying Vortex download:

Tue Sep 20 11:37:22 AM EDT 2022 INFO - getGameOS - Starting game OS detection
Tue Sep 20 11:37:22 AM EDT 2022 WARN - getGameOS - Could not extract the full game binary path from the incoming game launch command, so assuming this is a Windows game!
Tue Sep 20 11:37:22 AM EDT 2022 INFO - setWin - '' determined to be a Windows Game
Tue Sep 20 11:37:22 AM EDT 2022 INFO - createDefaultCfgs - createProtonList:
Tue Sep 20 11:37:22 AM EDT 2022 INFO - createDefaultCfgs - createProtonList end
Tue Sep 20 11:37:22 AM EDT 2022 INFO - listAllSettingsEntries - '/dev/shm/steamtinkerlaunch/setentries.txt' already exists - nothing to do
Tue Sep 20 11:37:22 AM EDT 2022 INFO - createDefaultCfgs - STOP
Tue Sep 20 11:37:22 AM EDT 2022 SKIP - listSteamLibraries - not recreating already available '/dev/shm/steamtinkerlaunch/SteamLibraries.txt'
Tue Sep 20 11:37:22 AM EDT 2022 INFO - setSteamLibraryPaths - STEAM_COMPAT_LIBRARY_PATHS set to '/run/media/DeckLinux/steamapps:/home/deck/.local/share/Steam/steamapps'
Tue Sep 20 11:37:22 AM EDT 2022 INFO - setSteamLibraryPaths - STEAM_COMPAT_MOUNTS set to '/home/deck/.local/share/Steam/steamapps/common/Steamworks Shared:/home/deck/.local/share/Steam/steamapps/common/SteamLinuxRuntime:/home/deck/.local/share/Steam/steamapps/common/SteamLinuxRuntime_soldier'
Tue Sep 20 11:37:22 AM EDT 2022 INFO - setSteamLibraryPaths - STEAM_COMPAT_TOOL_PATHS set to '/home/deck/.local/share/Steam/steamapps/common/SteamLinuxRuntime:/home/deck/.local/share/Steam/steamapps/common/SteamLinuxRuntime_soldier:/home/deck/.local/share/Steam/steamapps/common/Steamworks Shared'
Tue Sep 20 11:37:22 AM EDT 2022 INFO - main - Checking internal dependencies:
Tue Sep 20 11:37:22 AM EDT 2022 INFO - checkIntDeps - Skipping yad version check on SteamDeck
Tue Sep 20 11:37:22 AM EDT 2022 INFO - main - Initializing first Proton:
Tue Sep 20 11:37:22 AM EDT 2022 INFO - initOldProtonArr - Creating an initial array with available Proton versions using the file '/dev/shm/steamtinkerlaunch/ProtonCSV.txt' which was created during a previous run
Tue Sep 20 11:37:22 AM EDT 2022 INFO - initFirstProton - Initializing Proton
Tue Sep 20 11:37:22 AM EDT 2022 INFO - initFirstProton - Initial Proton version 'FIRSTUSEPROTON' from '/home/deck/.config/steamtinkerlaunch/default_template.conf' is 'proton-7.0-4'
Tue Sep 20 11:37:22 AM EDT 2022 INFO - main - Initializing default window resolution
Tue Sep 20 11:37:22 AM EDT 2022 INFO - setInitWinXY - Using '1280x800' from config '/dev/shm/steamtinkerlaunch/defres.txt'
Tue Sep 20 11:37:22 AM EDT 2022 INFO - main - Checking command line: incoming arguments 'vortex download'
Tue Sep 20 11:37:22 AM EDT 2022 INFO - StatusWindow - for 'Downloading 'Vortex''
Tue Sep 20 11:37:22 AM EDT 2022 INFO - getLatestVortVer - Search for latest Vortex stable Release
Tue Sep 20 11:37:23 AM EDT 2022 INFO - getLatestVortVer - Found ''
Tue Sep 20 11:37:23 AM EDT 2022 SKIP - dlLatestVortex - No VORTEXSETUP defined - nothing to download - skipping

I tried this as well using a release version but I did not capture logs, just noticed similar problems. I will try again as a release version just to rule out in-development code.

sonic2kk commented 2 years ago

Thanks for the report. Someone else in #589 reported having a similar issue with MO2 installing. It seems like from the logs that Vortex as well might be having a similar problem, though please note that there may be general issues at the moment with Vortex on Linux.

There is an ongoing investigation into the issues with MO2 and Steam Deck. Thanks for reporting though!

Also, you can only use the latest Git on Steam Deck. STL will always automatically download the latest Git release on Steam Deck to get the latest fixes. Steam Deck support for STL is still a work in progress, and we rely on issues like this one to try and fix the problems that arise :)

srolfe commented 2 years ago

Ok, thanks @sonic2kk. I did see #589 but wasn't sure if they were related or not.

I'll watch that thread then to see what you all figure out on this issue. Thanks again!

sonic2kk commented 2 years ago

There was a lot going on in that thread so no worries, thanks once again ! 😃

@frostworx this log I believe has a more up-to-date log than the other issue. The line at the top about no Mod.Organizer release is perhaps part of the problem. Is the wget to set the MO2SETUP var failing?

verbes4 commented 2 years ago

im having issues installing MO2 as well, havent checked the logs but so far but its looking like this issue and https://github.com/frostworx/steamtinkerlaunch/issues/589

sonic2kk commented 2 years ago

@verbes4 Is this also on Steam Deck or on desktop Linux?

I haven't tried on a PC yet but I'm hoping to soon, so just wondering

verbes4 commented 2 years ago

@verbes4 Is this also on Steam Deck or on desktop Linux?

I haven't tried on a PC yet but I'm hoping to soon, so just wondering

@sonic2kk im on my desktop, Arch Linux with KDE

sonic2kk commented 2 years ago

I also use Arch Linux with KDE. That is very interesting, thank you! I have a laptop running the same which I will try installing MO2 via STL on in a little bit.

It seems like MO2 is, for some reason, not installing working anymore. Thankfully I don't think this is an issue relating to Wine, I think the issue is with getting and downloading the MO2 executable, based on

Tue Sep 20 11:33:27 AM EDT 2022 ERROR - getLatestMO2Ver - Could not find any 'Mod.Organizer' Release
verbes4 commented 2 years ago

awesome. i just checked my log now, and im also getting that error. Tue Sep 20 05:48:21 PM BST 2022 ERROR - getLatestMO2Ver - Could not find any 'Mod.Organizer' Release like you said, it looks like it cant download mo2 for some reason

heres my full log incase it might be of any use steamtinkerlaunch.log

sonic2kk commented 2 years ago

Thank you! If it's not too much trouble, could you go to ~/.config/steamtinkerlaunch, open the url.conf folder and search for "Mod Organizer 2 DL URL". If you can find it please send the line with MO2DLURL.

This is where STL stores the download location of MO2. Basically I want to make sure this is set correctly. If it isn't, that would help explain why it can't find MO2 (if this url is not set, the code to check the MO2 version won't work because in essence it isn't checking a valid link)

sonic2kk commented 2 years ago

I just tested running the MO2 version check code manually (outside of STL) with the following and it returns nothing:

WGET="/usr/bin/wget"
MO2DLURL="https://github.com/ModOrganizer2/modorganizer/releases"
MO2SET="Mod.Organizer"

MO2SETUP="$("$WGET" -q "${MO2DLURL}" -O - 2> >(grep -v "SSL_INIT") | grep "exe" | grep -m1 "$MO2SET" | grep -oE "${MO2SET}[^\"]+")"
echo "$MO2SETUP"

It would seem somewhere along the way, something is being lost :frowning_face:

sonic2kk commented 2 years ago

I think maybe this issue is related to how the page content on GitHub is returned. It looks like it might be returned differently now.

Running MO2SETUP="$("$WGET" -q "${MO2DLURL}" -O - 2> >(grep -v "SSL_INIT") | grep "exe")" does not return any relevant executable now, just changelog information.

sonic2kk commented 2 years ago

Okay, it definitely looks like running wget on GitHub does not return the assets anymore. I ran the following:

WGET="/usr/bin/wget"
MO2DLURL="https://github.com/ModOrganizer2/modorganizer/releases"
MO2SET="Mod.Organizer"

MO2SETUP="$("$WGET" -q "${MO2DLURL}" -O - 2> >(grep -v "SSL_INIT"))"
echo "$MO2SETUP" > mo2info.txt

Then searched in the text file it created. I removed anything for v2.4.3 and just did a search for Mod.Organizer and nothing returned. It looks like the assets component is loaded lazily now, meaning its fetched and loaded after the page!

Relevant section from MO2 Releases page of Assets HTML Note in particular the `include-fragment` and `loading=lazy`. This would also explain why in the above logs, Vortex is failing to download as well! ```html ```

There are a couple of things we could do to amend this:

  1. Poll the GitHub API directly to get the version. This has a potential problem of either being difficult to implement in Bash, and also potentially having users hit the API rate limit (unlikely probably, but still something to keep in mind)
  2. We hardcode the version and directly download from https://github.com/ModOrganizer2/modorganizer/releases/expanded_assets/$MO2VER. MO2 should prompt when an update is available, and v2.4.5 is in development as we speak.
  3. Fetch the latest MO2 version in some other way and download from https://github.com/ModOrganizer2/modorganizer/releases/expanded_assets/$MO2VER. Release tags might not be the way to go as they might have development version tags. Maybe we can get it from the GitHub repository page itself under the "Releases" section? from the existing releases page. We wget that and somehow fetch the version from that, then we can download directly from the expanded_assets page. You can see what this looks like by going to https://github.com/ModOrganizer2/modorganizer/releases/expanded_assets/v2.4.4 in your browser.
  4. Potentially find some way to make wget wait for the entire page to load. Not sure how to guarantee this, though. Doesn't seem possible as wget doesn't care about JavaScript.

We should be able to fix this! And the fix for Vortex should be somewhat similar.

verbes4 commented 2 years ago

Thank you! If it's not too much trouble, could you go to ~/.config/steamtinkerlaunch, open the url.conf folder and search for "Mod Organizer 2 DL URL". If you can find it please send the line with MO2DLURL.

This is where STL stores the download location of MO2. Basically I want to make sure this is set correctly. If it isn't, that would help explain why it can't find MO2 (if this url is not set, the code to check the MO2 version won't work because in essence it isn't checking a valid link)

im not sure if this is still needed but ## Mod Organizer 2 DL URL MO2DLURL="https://github.com/ModOrganizer2/modorganizer/releases" im glad we know what the problem is now 🙂

sonic2kk commented 2 years ago

It's still good to know, thank you very much for following up! Sorry that I've been kind of thinking out loud in my past few comments :sweat_smile:

There should be a relatively straightforward solution to all of this, basically we just need to change the download URL since we can't actually see the releases from GitHub now - They're loaded "lazily" mean GitHub polls for them asynchronously while the page is loading. If you go to the MO2 Releases section you might see a spinning wheel where the assets section is, which is where GitHub is trying to fetch the latest releases.

If we can get the latest version (can probably grep for it on the releases page we download), we can change the download URL to point to an asset on the expanded_assets page.

sonic2kk commented 2 years ago

I wrote some very messy Bash code to correctly fetch the name for the MO2 executable from the updated location at the expanded_assets page.

# Variable setup
WGET="/usr/bin/wget"
GHURL="https://github.com"
MO2DLURL="${GHURL}/ModOrganizer2/modorganizer/releases"
MO2TAGURL="${GHRUL}/ModOrganizer2/modorganizer/tags"
MO2EXPANDEDASSETSURL="${GHURL}/ModOrganizer2/modorganizer/releases/expanded_assets"
MO2RELEASETAG="/ModOrganizer2/modorganizer/releases/tag/"
MO2SET="Mod.Organizer"

# Get latest MO2 ver from Releases page by greping for all elements with $MO2RELEASETAG, getting the first (latest) one and stripping out the version string from the rest of the URL 
MO2LATESTRELEASEURL="$("$WGET" -q "${MO2TAGURL}" -O - 2> >(grep -v "SSL_INIT") | grep -m1 "$MO2RELEASETAG" | grep -oE "${MO2RELEASETAG}[^\"]+")"
MO2LATESTVER="${MO2LATESTRELEASEURL##*/}"

# Get URL to the expanded_assets section
MO2LATESTASSETURL="${MO2EXPANDEDASSETSURL}/${MO2LATESTVER}"

# With an updated MO2 URL pointing at the expanded_assets page, use the existing code to grep the MO2 executable name
MO2SETUP="$("$WGET" -q "${MO2LATESTASSETURL}" -O - 2> >(grep -v "SSL_INIT") | grep "exe" | grep -m1 "$MO2SET" | grep -oE "${MO2SET}[^\"]+")"

# Visual output
echo "Latest MO2 release is: ${MO2LATESTVER}"
echo "Latest MO2 assets page is: ${MO2LATESTASSETURL}"
echo "MO2 setup is: ${MO2SETUP}"

This is more of a "proof of concept" that it can be done and how it could be done. However, I think the solution we can use for SteamTinkerLaunch is to have a generic function to fetch expanded assets from GitHub for MO2 and Vortex.

sonic2kk commented 2 years ago

Okay, I wrote a generic function in a test Bash file that correctly fetches the latest executable names for MO2 and Vortex.

# Variable setup
WGET="/usr/bin/wget"
GHURL="https://github.com"

MO2PROJURL="${GHURL}/ModOrganizer2/modorganizer"
VORTEXPROJURL="${GHURL}/Nexus-Mods/Vortex"

MO2SET="Mod.Organizer"
VORTEXSET="vortex-setup"

function getLatestGitHubExeVer {
    SETUPNAME="$1"
    PROJURL="$2"

    RELEASESURL="${PROJURL}/releases"
    EXPANDEDASSETSURL="${RELEASESURL}/expanded_assets"
    TAGSURL="${PROJURL}/tags"

    TAGSGREP="${RELEASESURL#"$GHURL"}/tag"

    LATESTTAG="$("$WGET" -q "${TAGSURL}" -O - 2> >(grep -v "SSL_INIT") | grep -m1 "$TAGSGREP" | grep -oE "${TAGSGREP}[^\"]+")"
    LATESTVER="${LATESTTAG##*/}"

    LATESTRELEASEURL="${EXPANDEDASSETSURL}/${LATESTVER}"

    SETUPFILE="$("$WGET" -q "${LATESTRELEASEURL}" -O - 2> >(grep -v "SSL_INIT") | grep "exe" | grep -m1 "$SETUPNAME" | grep -oE "${SETUPNAME}[^\"]+")"
    echo "${SETUPFILE}"
}

MO2SETUP="$(getLatestGitHubExeVer ${MO2SET} ${MO2PROJURL})"
VORTEXSETUP="$(getLatestGitHubExeVer ${VORTEXSET} ${VORTEXPROJURL})"

echo "MO2 setup exe is: ${MO2SETUP}"
echo "Vortex setup exe is: ${VORTEXSETUP}"

This seems to correctly return Mod.Organizer-2.4.4.exe and vortex-setup-1.6.10.exe.

Gonna see if I can tie this into SteamTinkerLaunch. I can foresee a few challenges with defining the URLs for each project and then telling the MO2 and Vortex downloaders to download from the expanded_assets page, but we're getting there! The above code snippet resolves the previous issue of getting the MO2SETUP and VORTEXSETUP names at least, so half the battle is won!

verbes4 commented 2 years ago

i noticed in the other issue, you said it might take some time for it to get merged. is there any way to get around the error for now, like downloading the exe manually and putting it wherever STL expects it?

sonic2kk commented 2 years ago

I was thinking about this, you might be able to manually download the executable and put it into ~/.config/steamtinkerlaunch/downloads/mo2, then from terminal run steamtinkerlaunch mo2 install. However since STL can't get the version, this might not work. I'm not sure if running install will skip the version check if it knows MO2 is already in the STL Downloads folder.

You can downloaded the latest MO2 setup exe from here: https://github.com/ModOrganizer2/modorganizer/releases/


In better news, it seems like my fix works for MO2! It was incredibly easy, the function I wrote was only needed to get the executable version - The download URL is still the same, so that function was only needed to correctly get the version. I was successfully able to download and install MO2 up to where it asked me to create an instance. I don't have any games on my laptop that MO2 supports so I cancelled, but it was able to download and run the installer!

Next is doing the same thing for Vortex (hopefully very minimal effort as well).

verbes4 commented 2 years ago

I was thinking about this, you might be able to manually download the executable and put it into ~/.config/steamtinkerlaunch/downloads/mo2, then from terminal run steamtinkerlaunch mo2 install. However since STL can't get the version, this might not work. I'm not sure if running install will skip the version check if it knows MO2 is already in the STL Downloads folder.

looks like it still tries to download mo2 even if the exe is available, which results in it not installing. is there a page anywhere on the wiki about building STL? i would love to get your fix as soon as the pr is up so i can start modding oblivion haha

sonic2kk commented 2 years ago

is there a page anywhere on the wiki about building STL? i would love to get your fix as soon as the pr is up so i can start modding oblivion haha

You can build and run STL from source, including the one on my branch, but this might be more complicated to uninstall.

How have you currently installed STL? If you've installed it from the AUR you might actually be ok. In that case once the PR is up (I don't recommend doing it yet as the branch isn't even up yet!) you can do the following (proceed relatively at your own risk!):

  1. Remove your previous installation of STL with something like yay -R steamtinkerlaunch (or however you installed it :slightly_smiling_face:)
  2. Download my fork with git clone https://github.com/sonic2kk/steamtinkerlaunch sonic2kk-stl (this will download it to a folder called sonic2kk-stl)
  3. Run cd sonic2kk-stl (moves you into that folder)
  4. Run git checkout fix-github-ver-mo2-vortex (that gets you into the branch that has the relevant fixes! Very important step!)
  5. Run rm -rf /dev/shm/steamtinkerlaunch (removes any lingering files)
  6. Run sudo make install (actually installs STL)
  7. Run ./steamtinkerlaunch compat add (adds STL as a compatibility tool)
  8. Restart Steam (needed for the compat tool location to refresh)
  9. Try to install MO2, either from Terminal or from the SteamTinkerLaunch Main Menu by pressing the Mod Organizer 2 button (I'd recommend this way)
  10. Enable MO2 as GUI Mode from the Game Menu (under "Mod Organizer 2" settings)
  11. Profit, hopefully!

If you ever want to revert back to a stable STL, you can probably just do the following (I hope!):

  1. Run rm -rf /dev/shm/steamtinkerlaunch (remove any lingering files)
  2. Run steamtinkerlaunch compat del (remove compat tool)
  3. Install STL from the AUR again, probably you'll want to go with the Git package with something like yay -S steamtinkerlaunch-git (this should overwrite any existing STL files in /usr/bin and other system directories)
  4. Restart Steam (update compat tool locations)
  5. Now you should be using an official build of STL again

I am not totally sure if the above will work and I would recommend having some patience for this to be merged first unless you're confident that you know what you're doing on your system! Maybe as an Arch user I don't have to tell you that :wink:


Currently I'm working on fixing up Vortex and getting it to use the new function. Once I have that I'll open my PR.

P.S. I've modded Oblivion with MO2 and STL. It works great! But sometimes some mods (I think the ones that were made for use with WyreBash and OBMM) can have a couple of problems. See my writeup on the MO2 wiki about some problems you might run into: https://github.com/frostworx/steamtinkerlaunch/wiki/Modding#MO2


Also please note that using any code not from the official STL repository is always subject to change and has not been reviewed by Frostworx. There may be bugs, the chosen solution may not be ideal, there could be lots of Unforeseen Consequences. Basically, "Here Be Dragons!", and if you want a stable experience stick to using code that has been vetted by Frostworx!

sonic2kk commented 2 years ago

@verbes4 The PR is up if you're feeling brave. Please don't feel like you have to try this, I am only pinging you because I know you expressed interest in trying it out so I wanted to let you know it's up.

Good luck if you do try it, no worries if you don't.

verbes4 commented 2 years ago

great timing, just used your fix and got mo2 installed, thanks 🙂 ill deal with the consequences of installing it this way once i get there haha, your steps you listed for reverting to the git package seem like they should work when the time comes, anything else is on me

sph432 commented 2 years ago

Thanks, your patch does work.

sonic2kk commented 2 years ago

Hell yeah, I'm glad you both got it working! Hopefully it gets merged in soon, there might just be some discussion over the approach taken. I've tried to justify it in the PR but given my inexperience with Bash, there may be some additional feedback. The end result, that is MO2 and Vortex installing correctly, should always be the same, but the code still needs review in case there is something I didn't catch or any improvements that can be made :smile:

sonic2kk commented 2 years ago

Problem should be fixed in latest master :+1:

srolfe commented 2 years ago

Thanks @sonic2kk! It works perfectly now =)