sonicretro / s1disasm

Sonic 1 Disassembly
336 stars 97 forks source link

Correct names for debug movement variables #88

Closed MDTravisYT closed 2 months ago

MDTravisYT commented 4 months ago

Beforehand, the variable names for debug movement were incorrectly labelled for being for X and Y movement speed, when in reality, movement speed is global for all directions. The changes are as followed: When one of the directional buttons is held, it counts the value previously listed as v_debugxspeed down until it reaches $01. Afterwards, it starts increasing the value next to it, v_debugyspeed, which is the true speed. I've changed v_debugxspeed to v_debugspeedtimer and v_debugyspeed to v_debugspeed to better explain its behavior. This change aligns with the official label in the Sonic 1 source code, which calls the new v_debugspeedtimer simply edittimer, and v_debugyspeed as edittimer+1.

Clownacy commented 2 months ago

Thanks for this!