search

sonyxperiadev / device-sony-lena

10 stars 12 forks source link

Bluetooth Fixes. #29

Closed ShujathMohd closed 1 year ago

ShujathMohd commented 1 year ago

In this we are dropping the non existent package android.hardware.bluetooth@1.0-impl-qti and including the android.hardware.bluetooth@1.0-impl.

error : E audiohalservice: Failed to dlopen android.hardware.bluetooth.audio-impl.so: dlopen failed: library "android.hardware.bluetooth.audio-impl.so" not found

And the second commit we are switching to android.hardware.bluetooth@1.0-service from android.hardware.bluetooth@1.0-service-qti

We are currently using android.hardware.bluetooth@1.0-service-qti which is from Android 9(https://github.com/sonyxperiadev/vendor-qcom-opensource-bluetooth/tree/master/interfaces/bluetooth/1.0/qti) Let us switch to the android.hardware.bluetooth@1.0-service provided in AOSP, which contains the same service but with updated rc file (https://android.googlesource.com/platform/hardware/interfaces/+/refs/tags/android-14.0.0_r10/bluetooth/1.0/default/) With this change we can drop vendor/qcom/opensource/Bluetooth

MarijnS95 commented 1 year ago

image Friendly request to backtick (`) names so that they don't become clickable emails :+1:

MarijnS95 commented 1 year ago

Can you add a description to the first commit? It doesn't explain why android.hardware.bluetooth@1.0-impl-qti suddenly doesn't exist, was it available on an older version of Android? If it was never there, why do we suddenly need the non--qti version?

MarijnS95 commented 1 year ago

Also please have a descriptive PR title :wink:. Don't forget the branchname prefix, so that we know (in the future!) on which Android version this became applicable!

ShujathMohd commented 1 year ago

Idea is good, but we should investigate using the latest version or jump straight to AIDL at some point.

Sure, lets work on it after this :)

jerpelea commented 1 year ago

please add the commit message on the first patch

ShujathMohd commented 1 year ago

please add the commit message on the first patch

Done

ShujathMohd commented 1 year ago

Can you add a description to the first commit? It doesn't explain why android.hardware.bluetooth@1.0-impl-qti suddenly doesn't exist, was it available on an older version of Android? If it was never there, why do we suddenly need the non--qti version?

I am not sure in which android version it existed, but can see audioservice spamming about missing android.hardware.bluetooth.audio-impl.so

MarijnS95 commented 1 year ago

I am not sure in which android version it existed

Maybe it used to reside on /odm? @jerpelea do you remember?

but can see audioservice spamming about missing android.hardware.bluetooth.audio-impl.so

Bluetooth audio != the HCI HAL itself! This commit message:

E audiohalservice: Failed to dlopen android.hardware.bluetooth.audio-impl.so: dlopen failed: library "android.hardware.bluetooth.audio-impl.so" not found

Is irrelevant :(