search

sonyxperiadev / gerrit-events

MIT License
47 stars 62 forks source link

Add "private" and "wip" states to Change (Continued) #81

Closed darfink closed 6 years ago

darfink commented 6 years ago

Since the previous pull request (#73) became stale, I've rebased the changes onto latest master, with a spelling correction and a minor fix for the additional tests.

If this pull request becomes merged, it would be great to merge gerrit-trigger-plugin#364 as well.

darfink commented 6 years ago

@rsandell

darfink commented 6 years ago

I never did run checkstyle since it wasn't mentioned in the README.

Anyhow, a few whitespace issues were detected but I've fixed them. Checkstyle did complain about isPrivate argument hiding the corresponding field. I've added an ignore directive but you may prefer another solution.

cashlalala commented 6 years ago

Vote for this PR! Look forward to have it in the near future! :)

darfink commented 6 years ago

@rsandell any more input on this?

cashlalala commented 6 years ago

:) thx