search

soonevel / TechCreate

0 stars 0 forks source link

Validation on start and end index #4

Open wj-0816 opened 1 month ago

wj-0816 commented 1 month ago

https://github.com/soonevel/TechCreate/blob/706645e41f3f4131892bc122664848628d57d87a/src/main/java/org/example/Generator.java#L37

Yes, it's a valid concern. you can try to implement it.

Additionally, you might want to use a //TODO: comment to distinguish this note from regular comments. This can serve as a reminder for yourself or others to implement the check or improve this part of the logic.

https://www.jetbrains.com/help/idea/using-todo.html

soonevel commented 1 month ago

Ah, thanks for raising the use of TODO and FIXME to my attention. Much appreciated. Addressed the index validation as follows. https://github.com/soonevel/TechCreate/blob/9ccf1b33fa39cec8825c2a4db6ae06c92ece9dfd/src/main/java/org/example/Generator.java#L47-L50

wj-0816 commented 1 month ago

Would be better if you can enhance to include the line number. So that when error occur we can quickly identify the line that has a problem, especially for error like duplicated columnName.

soonevel commented 1 month ago

Noted with thanks. Included line number for each error message.