sopel-irc / sopel-github

GitHub plugin for Sopel
Other
3 stars 13 forks source link

Inline issue references generate error spam #127

Open dgw opened 1 year ago

dgw commented 1 year ago

In a channel where people like to talk about numbered stuff in contexts other than issues, it's pretty easy to trigger errors from sopel-github when a number higher than the maximum issue/PR number in the linked repo is mentioned.

We should suppress "[GitHub] API says this is an invalid issue" errors for inline refs without a (user/)repo attached.

dgw commented 9 months ago

Another edge case: A link such as https://docs.github.com/en/site-policy/acceptable-use-policies/github-acceptable-use-policies#4-spam-and-inauthentic-activity-on-github generates an error because the plugin looks for an issue at acceptable-use-policies/github-acceptable-use-policies#4 (which doesn't exist, at time of writing).

In summary:

dgw commented 4 months ago

Errors are blanket-suppressed with #136. For a more nuanced approach, as noted in that PR, it would be better to wait until after some long-overdue code cleanup/refactoring can happen.