search

sorenrehkopf / custom-rick-roll

386 stars 64 forks source link

Rick roll not displaying #1

Closed zombiestruck closed 4 years ago

zombiestruck commented 4 years ago

On changing the video from ./assets/nggyunglud.mp4 to /assets/nggyunglud.mp4 it works. It just requires something to update the source for it to load. Upon changing it back to ,/assets/nggyunglud.mp4 it reloads.

rptoma commented 4 years ago

Can confirm that all the generated URLs have a black video.

MrSpark333 commented 4 years ago

It happened to me also. But I realize the video was there/ But it wasn't auto-playing. But clicking with right button I could choose to play the video (And pause it).

Judjim commented 4 years ago

It seems like Chrome doesn't autoplay, but IE and Edge do. :-(

CromebookCoder commented 4 years ago

I attempted to rick roll my friend and it didn't show

sorenrehkopf commented 4 years ago

Hello! I am just now seeing these and have not been aware that anyone was really using the site. I can repro the issue and will get it fixed soon. Sorry for the delay everyone and thanks for reporting!

CromebookCoder commented 4 years ago

Ty

On Sat, Aug 15, 2020, 10:35 PM Soren notifications@github.com wrote:

Hello! I am just now seeing these and have not been aware that anyone was really using the site. I can repro the issue and will get it fixed soon. Sorry for the delay everyone and thanks for reporting!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sorenrehkopf/custom-rick-roll/issues/1#issuecomment-674474047, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQGGWYPJS4S7GUYPB7T34K3SA5HWLANCNFSM4MHE2LPA .

sorenrehkopf commented 4 years ago

This issue should now be resolved. Unfortunately I had to change the experience a bit due to a policy for chrome that went into effect since I was last working on this that prevents autoplaying videos with sound, and requires user interaction before a video can be played via JS. Users will now see a fake "accept our cookies" message which will trigger the video when interacted with.