search

sorenrehkopf / custom-rick-roll

386 stars 64 forks source link

I can pause the video, why? #20

Closed ZaldyColinares closed 3 years ago

ZaldyColinares commented 3 years ago

Screenshot_2021-01-19-10-44-06-06_f936c31d0041139c630017c44e194ebf

sorenrehkopf commented 3 years ago

Hey @ZaldyColinares!

Thanks for reporting! That is unexpected and unintended. Do you have your device and browser information?

Full disclaimer I very rarely work on this project but if you leave device / browser info and a few repro steps I'll look into it next time I get around to making updates.

Thanks!

ZaldyColinares commented 3 years ago

Well, I used Samsung Internet Explorer

On Sun, Feb 7, 2021, 2:15 PM Soren notifications@github.com wrote:

Hey @ZaldyColinares https://github.com/ZaldyColinares!

Thanks for reporting! That is unexpected and unintended. Do you have your device and browser information?

Full disclaimer I very rarely work on this project but if you leave device / browser info and a few repro steps I'll look into it next time I get around to making updates.

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sorenrehkopf/custom-rick-roll/issues/20#issuecomment-774610972, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANLD2FXPGXHKSBHVZUJTGHTS5YVWXANCNFSM4WIDLI7A .

Boptima commented 3 years ago

I can also pause the video if I use tab to select the pause button. Works on edge and firefox

profess1onal commented 3 years ago

Pretty sure it is designed for Chromium based browsers.

remenkemi commented 3 years ago

Pretty sure it is designed for Chromium based browsers.

Samsung Internet is Chromium based and Firefox isn't. Yet it works in Firefox but not Samsung Internet.

markkhoo commented 3 years ago

I can also pause the video if I use tab to select the pause button. Works on edge and firefox

Yea tabbing through to pause still works. But I feel like this is fine. I don't think the average user would immediately think about tabbing right as they are getting Rick Rolled.

sorenrehkopf commented 3 years ago

Hey everyone, since it sounds like this is based on using keyboard controls to access the video controls, I'm gonna go ahead and close this out.

As @markkhoo correctly calls out, it's not the end of the world if the user is able to tab and pause the video. It's really not even the end of the world if they're able to pause the video normally to be entirely honest, and I may just remove that text from the generated pages since it has led to people opening these kinds of issues.

The main point is just to play the video without people realizing it. As long as that happens then they've been rolled. 👍