These are some changes that were left out before releasing 1.0.0a. Most of these changes are from issue #15. Some of the changes for issue #15 are split into PR #17 for easier inspection.
Detailed list:
Improved sphinx docs
cross_match.rough_match now takes a list of catalogs as argument.
db.get was renamed db.get_table.
remove user-specific filenames from task schedule.
the astromon-cat-obs-data script was renamed astromon-cross-match.
Fixes #15
Interface impacts
db.get was renamed db.get_table
cross_match.rough_match now has a catalogs argument
all db.*region* file had a db_file argument that did not follow the naming convention in other methods in the same module. That was fixed.
Testing
I will test code docstrings too.
Unit tests
[ ] Mac
[ ] Linux
Independent check of unit tests by [REVIEWER NAME]
[ ] [PLATFORM]:
Functional tests
End-to-end test with one OBSID. starting from an empty directory, the following command creates an astromon.h5 file with tables that should match the current master.
Description
These are some changes that were left out before releasing 1.0.0a. Most of these changes are from issue #15. Some of the changes for issue #15 are split into PR #17 for easier inspection.
Detailed list:
cross_match.rough_matchnow takes a list of catalogs as argument.astromon-cat-obs-datascript was renamedastromon-cross-match.Fixes #15
Interface impacts
db.getwas renameddb.get_tablecross_match.rough_matchnow has acatalogsargumentdb.*region*file had adb_fileargument that did not follow the naming convention in other methods in the same module. That was fixed.Testing
I will test code docstrings too.
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
End-to-end test with one OBSID. starting from an empty directory, the following command creates an
astromon.h5file with tables that should match the current master.The docs in a tmp directory: https://icxc.cfa.harvard.edu/aspect/tmp/jgonzalez/astromon/pr-17-docs